fix: syntax error#2096
Conversation
01dfe2a
into
Acode-Foundation:ajit/fix-fetch-auth-config
Greptile SummaryThis PR replaces the
Confidence Score: 4/5Safe to merge — the change is functionally identical to the code it replaces. The only differences from the original are cosmetic (indentation) and a loss of abstraction (hardcoded Cordova service/action strings instead of the src/lib/config.js — worth a second look on the indentation and the direct Important Files Changed
Reviews (1): Last reviewed commit: "fix: syntax error" | Re-trigger Greptile |
| @@ -62,7 +62,6 @@ system.getInstaller( | |||
| (error) => { | |||
| console.error(error); | |||
| config.IAP_AVAILABLE = typeof iap !== "undefined"; | |||
| }, | |||
| ); | |||
| }, 'System', 'getInstaller', []); | |||
There was a problem hiding this comment.
The success callback body is still indented at two tabs relative to the root level (a remnant of the prior
system.getInstaller layout where the arrow function started on its own indented line). Now that the arrow function opens inline with cordova.exec(, the body and closing brace are over-indented by one level compared to convention.
| cordova.exec( | |
| (installer) => { | |
| config.IAP_AVAILABLE = | |
| typeof iap !== "undefined" && | |
| installer != null && | |
| installer !== "null" && | |
| installer === "com.android.vending"; | |
| }, | |
| (error) => { | |
| console.error(error); | |
| config.IAP_AVAILABLE = typeof iap !== "undefined"; | |
| }, | |
| 'System', 'getInstaller', []); |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| @@ -62,7 +62,6 @@ system.getInstaller( | |||
| (error) => { | |||
| console.error(error); | |||
| config.IAP_AVAILABLE = typeof iap !== "undefined"; | |||
| }, | |||
| ); | |||
| }, 'System', 'getInstaller', []); | |||
There was a problem hiding this comment.
Direct
cordova.exec call bypasses the plugin abstraction
system.getInstaller (defined in src/plugins/system/www/plugin.js) was the canonical entry point for this operation. Replacing it with hardcoded cordova.exec(..., 'System', 'getInstaller', []) strings means any future rename of the service or action in the plugin won't be caught here automatically. Prefer calling system.getInstaller(success, error) if the reason the original call was removed is resolved, or leave a comment explaining why the direct call is necessary.
* Refactor API calls to use fetch instead of ajax and update configuration imports - Replaced ajax calls with fetch in sponsor, sponsors, and themeSetting pages. - Updated constants import to config in various files for better configuration management. - Improved error handling for API responses. - Adjusted logic for premium theme checks based on new config settings. - Enhanced cookie management in the Authenticator plugin for better security. - Fixed minor typos and improved code readability across multiple files. * fix: update BASE_URL to production and enhance plugin loading feedback * fix: update cookie settings to include HttpOnly for enhanced security * fix: hooks not working on free version (#2075) * fix: hooks not working on free version * Update hooks/post-process.js Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Update post-process.js --------- * fix: JSON formatting for UI zoom setting description * fix: JSON formatting and update translations * fix: JSON formatting and update translations * feat: IAP_AVAILABLE (#2086) * feat: IAP_AVAILABLE * fix: removed useless logs * feat: added web redirect (#2087) * feat: added web redirect * fix: removed useless code * fix: removed useless code * fix: added try/catch * fix: check owned before launching webpage * feat: added api to get installer package * feat: added installer check * format * fix: undefined error * Update src/lib/config.js Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fix: syntax error (#2096) * Refactor plugin installation and purchase handling - Enhanced HandleIntent function to validate plugin installation requests. - Modified getLoggedInUser method to return a Promise. - Removed IAP_AVAILABLE from config and adjusted related logic. - Improved main.js to handle app installation source and define appInstallSource. - Refactored plugin page to streamline plugin installation and purchase logic. - Added external purchase handling in plugin view and buttons. - Updated IAP plugin to track availability status. - Enhanced ListItem component to manage plugin installation and purchase flow. - Introduced shouldAllowExternalPurchase helper function for better purchase logic. * fix: update Android version and improve XML formatting * feat: add login prompt for viewing owned plugins and update language files * fix: formatting * fix --------- Co-authored-by: Ajit Kumar <dellevenjack@gmail> Co-authored-by: Rohit Kushvaha <oldisg131@gmail.com> Co-authored-by: Emmanuel Lobo <76094069+UnschooledGamer@users.noreply.github.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Raunak Raj <71929976+bajrangCoder@users.noreply.github.com>
No description provided.