fix(skill): require names for GitHub workflow steps#64
Conversation
📝 WalkthroughWalkthroughThis PR bumps the ChangesWriting Agent Relay Workflows v1.6.17 Release
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for writing-agent-relay-workflows (bumping its version to 1.6.17 in README.md and prpm.json). The changes in SKILL.md clarify that createGitHubStep requires a matching non-empty name field inside its configuration object to pass SDK validation, and updates all code examples and common mistakes tables to reflect this requirement. There are no review comments to address, and I have no additional feedback to provide.
|
Reviewed PR #64 and made fixes in Fixed:
Validated:
|
|
✅ pr-reviewer applied fixes — committed and pushed Reviewed PR #64 and made fixes in Fixed:
Validated:
|
There was a problem hiding this comment.
✅ pr-reviewer applied fixes — committed and pushed 69fb0ff to this PR. The notes below describe what changed.
Reviewed PR #64 and made fixes in skills/writing-agent-relay-workflows/SKILL.md.
Fixed:
- Clarified
createGitHubSteprequires its own non-emptyname. - Added builder compatibility guidance because released
WorkflowBuilder.step()can reject integration steps. - Corrected the GitHub
createBranchexample fromsource: 'main'tofromBranch: 'main'.
Validated:
- Parsed
prpm.json,prpm.lock, and PR context JSON. - Checked README/manifest version consistency for
writing-agent-relay-workflows1.6.17. - Ran targeted assertions over the updated doc text.
69fb0ff to
3700e08
Compare
|
Reviewed PR #64 and fixed the main issue I found: the docs still centered a Verification run locally:
|
|
Reviewed PR #64 and fixed the main issue I found: the docs still centered a Verification run locally:
|
There was a problem hiding this comment.
1) — fixes were not applied to the PR. The notes below are advisory and were not pushed.
Reviewed PR #64 and fixed the main issue I found: the docs still centered a .step(..., createGitHubStep(...)) recipe that fails on strict WorkflowBuilder.step() SDK versions. I updated the skill to make the config/YAML integration-step path the primary recipe, kept .step() as a compatibility note only, and aligned the checklist/table wording.
Verification run locally:
- JSON parse for
prpm.json,prpm.lock,.workforce/context.json - local markdown link check for changed docs
- SDK runtime config-construction check against
@agent-relay/sdk@7.1.1 - TypeScript check of the documented example against
@agent-relay/sdk@7.1.1 prpm publish --listprpm publish --dry-run --package writing-agent-relay-workflowswas attempted but requiresprpm login
|
Reviewed PR #64 and applied the unresolved reviewer fix in Changed the GitHub PR-shipping recipe so Validation run locally:
|
|
✅ pr-reviewer applied fixes — committed and pushed Reviewed PR #64 and applied the unresolved reviewer fix in Changed the GitHub PR-shipping recipe so Validation run locally:
|
There was a problem hiding this comment.
✅ pr-reviewer applied fixes — committed and pushed 0f67575 to this PR. The notes below describe what changed.
Reviewed PR #64 and applied the unresolved reviewer fix in skills/writing-agent-relay-workflows/SKILL.md.
Changed the GitHub PR-shipping recipe so createGitHubStep(...) is used as a full integration step inside workflows[].steps, not routed through strict WorkflowBuilder.step(). Added local GitHubStepExecutor wiring, YAML integration-step guidance, corrected the common mistakes table, and aligned the authoring rule wording.
Validation run locally:
- Parsed
prpm.json,prpm.lock, and.workforce/context.json - Checked README/manifest version consistency for
writing-agent-relay-workflows1.6.17 - Checked local markdown links in changed docs
- Dry-ran the revised SDK config against
@agent-relay/sdk@7.1.1 - Ran
npx prpm publish --list - Attempted
npx prpm publish --dry-run --package writing-agent-relay-workflows, but it requiresprpm login
Summary
Verification
Related: AgentWorkforce/ricky#144