-
Notifications
You must be signed in to change notification settings - Fork 557
feat(frontend): agent playground config panel + agent run-lane wire fixes #4850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
df26672
feat(frontend): agent config-panel UX, reconciled onto settled big-ag…
ardaerzin 0751074
fix(frontend): make the create/edit drawer fully usable for agents
ardaerzin 40c5720
feat(frontend): declare agent message format via x-ag-messages-format…
ardaerzin 3936d95
fix(frontend): emit agent custom tools as typed client config
ardaerzin e8db4b7
fix(frontend): cap agent tool-picker popover height so long action li…
ardaerzin 9eea2a1
Merge remote-tracking branch 'origin/big-agents' into fe-feat/agent-c…
ardaerzin f282916
fix(frontend): address PR review comments on the agent config panel
ardaerzin 927aa4a
fix(frontend): scope agent-chat sessions per surface so the drawer ca…
ardaerzin 176f67e
Merge big-agents into agent config panel (resolve HITL AgentChatSlice…
mmabrouk 71624b7
fix(frontend): reconcile harness picker labels to the oneOf/title int…
mmabrouk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Keep showing the failure when the stream dies after partial output.
AgentChatPanelnow stampsrunErroronto any failing assistant turn, but this component only renders that error whennoResponseis true. If the model emitted text/tool output before the stream failed, the top banner is gone and the turn now looks successful even though it terminated in error.💡 Minimal fix
const traceError = useAtomValue(traceDataSummaryAtomFamily(traceId ?? null)).error // A failure can reach us two ways: recorded on the trace (backend), or stamped onto the turn // FE-side from the useChat stream error (AgentChatPanel). Prefer whichever is present. const runError = getMessageRunError(message) const errorText = traceError || runError + const showError = !isStreaming && !!errorText @@ - const isError = noResponse && !!errorText + const isError = noResponse && showError - if (noResponse && !isError && !hasContent && precededByEmptyAssistant) return null + if (noResponse && !showError && !hasContent && precededByEmptyAssistant) return null @@ - const body = isError ? errorBody : defaultBody + const body = + showError && !isError ? ( + <div className="flex min-w-0 max-w-full flex-col gap-2"> + {defaultBody} + {errorBody} + </div> + ) : isError ? ( + errorBody + ) : ( + defaultBody + )Also applies to: 214-219, 327-328