[fix] Clean up Skill Template#4900
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Context
The skill authoring type was named
skill_config/SkillConfigeverywhere, out of step with theprompt-template/PromptTemplatenaming and with where agent authoring is headed (agent_template). The "config" word also clashes with the harness-config family. Two functional gaps rode along: a snippet revision dropped itsschemas.parameterson normalization (so a skill could not carry a parameter schema), and the agent config inlined the full skill schema instead of referencing it as a catalog type.This renames the skill authoring vocabulary to "template" and closes both gaps. No behavior change beyond those two fixes; the runtime shape is the same.
Changes
Rename
skill configtoskill template(mirrorsprompt-template):SkillConfigtoSkillTemplate,SkillConfigSchematoSkillTemplateSchema,parse_skill_config(s)toparse_skill_template(s).SkillConfigurationErrortoSkillValidationError. It is raised when a skill fails validation (bad name, unresolved embed, strict-model error), so the name now says what it is rather than carrying "config".__ag_type__goes from"skill_config"to"skill-template"(dash, likeprompt-template).SkillConfigControltoSkillTemplateControl(file + test renamed), props and doc refs updated.Snippets keep their parameters schema.
normalize_snippet_datakept onlyuri+parametersand droppedschemas. A snippet is non-runnable (no inputs/outputs), but it still needs to describe its own content. It now keepsschemas.parametersand drops only inputs/outputs and the execution surface (url/headers/runtime/script).Before:
After:
Agent config references the skill template by catalog ref. The
skillsfield used to inline the full skill schema as a union arm. It now points at theskill-templatecatalog type withx-ag-type-ref: "skill-template", the same way inputs referencemessages. The@ag.embedarm is unchanged; the full inline shape resolves from/catalog/types/skill-template.Web staleness fixed in passing. The skill control still used the pre-rename
is_platform/_agenta.signals. Updated tois_static/__ag__, withisPlatformSkilltoisStaticSkilland the "Platform skill" label to "Static skill".No back-compat: every renamed type is new on
big-agents, so this is a clean break with no aliases.Tests / notes
schemas.parameterssurvives while inputs/outputs drop, plus a no-schema case.@agenta/entity-ui, the renamed control test passes (12/12), eslint clean.agent_templateon a separate branch (chore/clean-up-agent-template). The keptis_platformvalue on the Fern-generated client still needs an OpenAPI regen.