Skip to content

[fix] Clean up Skill Template#4900

Merged
junaway merged 1 commit into
big-agentsfrom
chore/clean-up-skill-template
Jun 28, 2026
Merged

[fix] Clean up Skill Template#4900
junaway merged 1 commit into
big-agentsfrom
chore/clean-up-skill-template

Conversation

@junaway

@junaway junaway commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Context

The skill authoring type was named skill_config / SkillConfig everywhere, out of step with the prompt-template / PromptTemplate naming and with where agent authoring is headed (agent_template). The "config" word also clashes with the harness-config family. Two functional gaps rode along: a snippet revision dropped its schemas.parameters on normalization (so a skill could not carry a parameter schema), and the agent config inlined the full skill schema instead of referencing it as a catalog type.

This renames the skill authoring vocabulary to "template" and closes both gaps. No behavior change beyond those two fixes; the runtime shape is the same.

Changes

Rename skill config to skill template (mirrors prompt-template):

  • SkillConfig to SkillTemplate, SkillConfigSchema to SkillTemplateSchema, parse_skill_config(s) to parse_skill_template(s).
  • SkillConfigurationError to SkillValidationError. It is raised when a skill fails validation (bad name, unresolved embed, strict-model error), so the name now says what it is rather than carrying "config".
  • Catalog type __ag_type__ goes from "skill_config" to "skill-template" (dash, like prompt-template).
  • Web: SkillConfigControl to SkillTemplateControl (file + test renamed), props and doc refs updated.

Snippets keep their parameters schema. normalize_snippet_data kept only uri + parameters and dropped schemas. A snippet is non-runnable (no inputs/outputs), but it still needs to describe its own content. It now keeps schemas.parameters and drops only inputs/outputs and the execution surface (url/headers/runtime/script).

Before:

WorkflowRevisionData(uri=..., parameters=...)   # schemas dropped entirely

After:

WorkflowRevisionData(uri=..., parameters=..., schemas=JsonSchemas(parameters=...))

Agent config references the skill template by catalog ref. The skills field used to inline the full skill schema as a union arm. It now points at the skill-template catalog type with x-ag-type-ref: "skill-template", the same way inputs reference messages. The @ag.embed arm is unchanged; the full inline shape resolves from /catalog/types/skill-template.

Web staleness fixed in passing. The skill control still used the pre-rename is_platform / _agenta. signals. Updated to is_static / __ag__, with isPlatformSkill to isStaticSkill and the "Platform skill" label to "Static skill".

No back-compat: every renamed type is new on big-agents, so this is a clean break with no aliases.

Tests / notes

  • SDK: skills, catalog, and snippet suites green. The snippet test now asserts schemas.parameters survives while inputs/outputs drop, plus a no-schema case.
  • API workflows and services agent suites green.
  • Web: tsc clean on @agenta/entity-ui, the renamed control test passes (12/12), eslint clean.
  • Follow-up not in this PR: the agent config itself is renamed to agent_template on a separate branch (chore/clean-up-agent-template). The kept is_platform value on the Fern-generated client still needs an OpenAPI regen.

Copilot AI review requested due to automatic review settings June 28, 2026 08:45
@vercel

vercel Bot commented Jun 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Jun 28, 2026 8:46am

Request Review

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 28, 2026
@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 85f399ba-dd05-49b2-800d-a26981cf5ad6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/clean-up-skill-template

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dosubot dosubot Bot added python Pull requests that update Python code refactoring A code change that neither fixes a bug nor adds a feature labels Jun 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@junaway junaway mentioned this pull request Jun 28, 2026
12 tasks
@junaway junaway merged commit a997bac into big-agents Jun 28, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update Python code refactoring A code change that neither fixes a bug nor adds a feature size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants