Skip to content

Fixes for ITS/MFT decoding ensureContinuousROF effects.#15394

Draft
shahor02 wants to merge 2 commits into
AliceO2Group:devfrom
shahor02:pr_itsmftdec
Draft

Fixes for ITS/MFT decoding ensureContinuousROF effects.#15394
shahor02 wants to merge 2 commits into
AliceO2Group:devfrom
shahor02:pr_itsmftdec

Conversation

@shahor02
Copy link
Copy Markdown
Collaborator

Likely, some of the declared clusters are lost in the rectification of ROFs, this is not reason to throw. Instead, the rectification must be revised

shahor02 added 2 commits May 12, 2026 18:41
Due to the ensureContinuousROF some stray ROFs with clusters may be eliminated, which was not
accounted in the cluster vector.
@shahor02 shahor02 changed the title Do not throw on the mismatch between decoced and declared Nclusters Fixes for ITS/MFT decoding ensureContinuousROF effects. May 12, 2026
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for b1b5fcc at 2026-05-12 20:29:

## sw/BUILD/O2-full-system-test-latest/log
command /sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local14/prodtests/full-system-test/dpl-workflow.sh had nonzero exit code 128
[8759:BadMapCalibSpec]: [20:28:37][ERROR] Insufficient statistics: 1 entries in lowE histo, do nothing
[ERROR] Workflow crashed - PID 8778 (mft-entropy-encoder) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 8774 (its-entropy-encoder) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 8757 (its-tracker) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device its-tracker: pid 8757 (exit 128)
[ERROR]  - Device its-entropy-encoder: pid 8774 (exit 128)
[ERROR]  - Device mft-entropy-encoder: pid 8778 (exit 128)
[ERROR] SEVERE: Device its-tracker (8757) returned with 128


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/5a82ca081ee5c0a54711fe3f3da6d61af8a87108/slc9_x86-64/o2checkcode/1.0-local472/etc/modulefiles
++ alibuild-generate-module
+ HAS_BIN=
+ HAS_LIB=
+ HAS_CMAKE=
+ HAS_ROOT=
+ '[' 0 '!=' 0 ']'
+ cat
+ printf 'if ![ is-loaded '\''BASE/1.0'\'' ] {\n module load BASE/1.0\n}'
+ echo 'BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release'
BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release
+ FULL_BUILD_REQUIRES='CMake pytorch_cpuinfo json-c ninja defaults-release MPFR UUID FairCMakeModules Alice-GRID-Utils date O2-customization alibuild-recipe-tools double-conversion googlebenchmark Python-modules-list safe_int bz2 ninja-fortran'
+ echo 'FULL_BUILD_REQUIRES=CMake pytorch_cpuinfo json-c ninja defaults-release MPFR UUID FairCMakeModules Alice-GRID-Utils date O2-customization alibuild-recipe-tools double-conversion googlebenchmark Python-modules-list safe_int bz2 ninja-fortran'
FULL_BUILD_REQUIRES=CMake pytorch_cpuinfo json-c ninja defaults-release MPFR UUID FairCMakeModules Alice-GRID-Utils date O2-customization alibuild-recipe-tools double-conversion googlebenchmark Python-modules-list safe_int bz2 ninja-fortran
++ env
++ cut -f1 -d=
++ grep -v '^DEFAULT_'
++ grep -v PKGREVISION
++ grep -v ALIBUILD_RECIPE_TOOLS
++ grep REVISION
++ sed -e s/_REVISION//
+ for x in $(env | cut -f1 -d= | grep -v "^DEFAULT_" | grep -v PKGREVISION | grep -v ALIBUILD_RECIPE_TOOLS | grep REVISION | sed -e 's/_REVISION//')
++ eval 'echo $LIBFFI_REVISION'
+++ echo 10
+ REVISION_VALUE=10
++ eval 'echo $LIBFFI_VERSION'
+++ echo v3.2.1-alice1
+ VERSION_VALUE=v3.2.1-alice1
++ eval 'echo $LIBFFI_ROOT'
[0 more errors; see full log]

Full log here.

@shahor02 shahor02 marked this pull request as draft May 12, 2026 18:38
@shahor02
Copy link
Copy Markdown
Collaborator Author

Do not merge, CI failure is genuine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants