[ALICE 3] Fix sensitive volumes definition for FT3 #15397
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates FT3 simulation sensitive-volume registration so that sensor volumes are discovered correctly across newly introduced layoutFT3 naming schemes, and adds a volume-id → sensor-id lookup for ProcessHits().
Changes:
- Replace the previous
mLayerID-based sensitive-volume identification with anmActiveSensorMaplookup keyed by MC volume ID. - Redefine
defineSensitiveVolumes()to discover sensitive FT3 sensor volumes by iterating over all TGeo volumes and matching known naming signatures for multiple layouts. - Update FT3
DetectorROOT class version to reflect the data member change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
Detectors/Upgrades/ALICE3/FT3/simulation/src/Detector.cxx |
Reworks sensitive-volume discovery and ProcessHits() volume→sensor mapping. |
Detectors/Upgrades/ALICE3/FT3/simulation/include/FT3Simulation/Detector.h |
Replaces mLayerID with mActiveSensorMap and bumps ROOT class version. |
Comments suppressed due to low confidence (1)
Detectors/Upgrades/ALICE3/FT3/simulation/src/Detector.cxx:660
- When a matching sensitive volume is found, the map stores
mActiveSensorMap[volID] = iLayer, which is not sufficient to uniquely identify the sensor for digitization in the presence of multiple directions and/or multiple sensors per layer. Store a unique sensor/chip index here (e.g., includedirectionand, for segmented volumes, parse and include the sensor/stave indices from the volume name or hierarchy).
AddSensitiveVolume(v);
int volID = gMC ? TVirtualMC::GetMC()->VolId(vName.c_str()) : 0;
if (volID > 0) {
mActiveSensorMap[volID] = iLayer;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
njacazio
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sensitive volume names depend on FT3Base.layoutFT3 and were not correctly fetched for newly introduced layout options.
Additional checks are needed to retrieve the correct sensor ID for digitization.