Skip to content

[PWGCF] FemtoUniverse -- Improve K0Short histogramming.#16222

Draft
a-m-andrushko wants to merge 10 commits into
AliceO2Group:masterfrom
a-m-andrushko:hInvMassK0Short_fake_improved
Draft

[PWGCF] FemtoUniverse -- Improve K0Short histogramming.#16222
a-m-andrushko wants to merge 10 commits into
AliceO2Group:masterfrom
a-m-andrushko:hInvMassK0Short_fake_improved

Conversation

@a-m-andrushko
Copy link
Copy Markdown
Contributor

Improve yesterday's commit by simplifying K0Short histogramming.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for f88e918 at 2026-05-12 17:35:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for f88e918 at 2026-05-12 17:38:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 78a0451 at 2026-05-12 17:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:526:11: error: expected '}' before 'else'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:523:9: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:523:12: error: suggest explicit braces to avoid ambiguous 'else' [-Werror=dangling-else]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 78a0451 at 2026-05-12 17:50:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:526:11: error: expected '}' before 'else'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:523:9: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:523:12: error: suggest explicit braces to avoid ambiguous 'else' [-Werror=dangling-else]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@a-m-andrushko a-m-andrushko force-pushed the hInvMassK0Short_fake_improved branch from 78a0451 to aaeb1d4 Compare May 12, 2026 15:57
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for f236a96 at 2026-05-12 18:03:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:526:13: error: expected '}' before 'else'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for f236a96 at 2026-05-12 18:05:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:526:13: error: expected '}' before 'else'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:476:17: error: unused variable 'magFieldTesla' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:478:15: error: unused variable 'multCol' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:90: error: unused parameter 'groupPartsOne' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:474:139: error: unused parameter 'helRange' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft May 12, 2026 16:27
@a-m-andrushko a-m-andrushko force-pushed the hInvMassK0Short_fake_improved branch from f236a96 to a889d49 Compare May 12, 2026 16:38
@a-m-andrushko a-m-andrushko marked this pull request as ready for review May 12, 2026 16:38
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 2afcf28 at 2026-05-12 18:44:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 2afcf28 at 2026-05-12 18:47:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackV0Helicity.cxx:496:12: error: unused variable 'invMassK0Short' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft May 12, 2026 16:49
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 12, 2026

@a-m-andrushko I converted your PR to a draft because of the compilation warnings. Why did you mark it as ready for review again?

@a-m-andrushko
Copy link
Copy Markdown
Contributor Author

@a-m-andrushko I converted your PR to a draft because of the compilation warnings. Why did you mark it as ready for review again?

Sorry, my bad, I misclicked thinking it was a merge conflict error, I am working on the errors.

@a-m-andrushko
Copy link
Copy Markdown
Contributor Author

@a-m-andrushko I converted your PR to a draft because of the compilation warnings. Why did you mark it as ready for review again?

@a-m-andrushko I converted your PR to a draft because of the compilation warnings. Why did you mark it as ready for review again?

Sorry, my bad, I misclicked thinking it was a merge conflict error, I am working on fixing the errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants