Skip to content

hybrid: added system.hybrid_watermarks to inspect the Hybrid table watermarks#1789

Open
mkmkme wants to merge 3 commits into
antalya-26.3from
mkmkme/antalya-26.3/hybrid-system-table
Open

hybrid: added system.hybrid_watermarks to inspect the Hybrid table watermarks#1789
mkmkme wants to merge 3 commits into
antalya-26.3from
mkmkme/antalya-26.3/hybrid-system-table

Conversation

@mkmkme
Copy link
Copy Markdown
Collaborator

@mkmkme mkmkme commented May 14, 2026

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added system.hybrid_watermarks to introspect the hybrid tables watermarks

Documentation entry for user-facing changes

...

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

@mkmkme mkmkme added antalya port-antalya PRs to be ported to all new Antalya releases hybrid antalya-26.3 labels May 14, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

Workflow [PR], commit [fcc2455]

arthurpassos
arthurpassos previously approved these changes May 15, 2026
Copy link
Copy Markdown
Collaborator

@arthurpassos arthurpassos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


## Scope

Covers Hybrid tables visible to `getTablesIterator()` plus session-local temporary Hybrid tables — the same set that appears in `system.tables`. Temporary tables are emitted with `database = ''`, matching the `system.tables` convention.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covers Hybrid tables visible to getTablesIterator() plus session-local temporary Hybrid tables

does this really need to be in the user facing documentation?

continue;
}

/// Row contract case 1: N healthy rows, sorted by name for reference-file stability.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to sort it? wouldn't it make more sense to let the user do the sorting?

@alsugiliazova
Copy link
Copy Markdown
Member

Verification: PR #1789

PR-added test — all GREEN

03682_system_hybrid_watermarks6/6 OK across every stateless job that picked it up:

Job Status
Stateless tests (amd_asan, db disk, distributed plan, sequential) OK
Stateless tests (amd_debug, distributed plan, s3 storage, sequential) OK
Stateless tests (amd_debug, sequential) OK
Stateless tests (arm_asan, azure, sequential, 1/2) OK
Stateless tests (arm_asan, targeted) OK
Stateless tests (arm_binary, sequential) OK
Fast test SKIPPED (expected)

The new system.hybrid_watermarks table has clean positive coverage on all stateless flavors.

CI overview (head commit)

  • PR test workflow: 48 success / 48 skipped / 1 failure
  • Regression workflow: 28 success / 67 skipped / 3 failure (chronic baseline; one suite fewer than typical)

PR test-workflow failure

Check Verdict
Stateless tests (arm_binary, sequential)00157_cache_dictionary Pre-existing flake (78 fails / 25 PRs in 30d). Unrelated to Hybrid system-table diff.

Regression-workflow failures (chronic baseline on antalya-26.3)

Suite Fails
Swarms (Aarch64 + Release) 456
Parquet (Aarch64 + Release) 36
S3Export part (Aarch64 + Release) 28

Same fingerprint as sibling antalya-26.3 PRs (1788, 1782, 1776, 1783, 1775, …). S3Export partition was actually green on this run. No new failure modes.

Caveat — partial frontport

PR lands on antalya-26.3 while companion features from antalya-26.1 are still being frontported in parallel. Final re-verify recommended once the rest of the bundle lands.

Verdict

Safe to merge.

@alsugiliazova
Copy link
Copy Markdown
Member

Audit: PR #1789 — hybrid: added system.hybrid_watermarks to inspect the Hybrid table watermarks

AI audit note: generated by AI (Cursor agent, audit-review skill).

Confirmed defects

No confirmed defects in reviewed scope.

@alsugiliazova alsugiliazova added the verified Approved for release label May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

antalya antalya-26.3 hybrid port-antalya PRs to be ported to all new Antalya releases verified Approved for release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants