Repository navigation
clean(deployment): remove deprecated OnePerHost pod-distribution value - #2083
Merged
alex-zaitsev merged 5 commits intoOct 16, 2026
Merged
alex-zaitsev merged 5 commits into
alex-zaitsev merged 5 commits into
Conversation
Author
|
Hi team, following up to check if anyone has time to review this PR when convenient. Thanks! |
alex-zaitsev
self-requested a review
October 16, 2026 10:08
alex-zaitsev
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the deprecated and inactive
OnePerHostpod distribution value across the codebase, CRDs, templates, test requirements, and documentation as requested in #1978.OnePerHostwas deprecated dead code inpkg/apis/deployment/affinity.go: no normalizer or affinity builder handled it, and user-suppliedOnePerHostvalues silently resolved toUnspecifiedwithout generating anti-affinity rules.Key changes:
PodDistributionOnePerHostconstant and its entry frompodDistributionTypesslice inpkg/apis/deployment/affinity.go.pkg/apis/deployment/affinity_test.goverifying thatOnePerHostpasses through uncanonicalized as unrecognized.OnePerHostfrom CRD enums acrossdeploy/operator/parts/crd.yaml,deploy/builder/templates-install-bundle/, anddeploy/helm/clickhouse-operator/crds/.docs/custom_resource_explained.md,docs/chit-examples/104-templates.yaml,config/chi/templates.d/,deploy/helm/clickhouse-operator/values.yaml) to use standardpodDistributionwithClickHouseAntiAffinity.tests/requirements/requirements.mdandtests/requirements/requirements.py.Verification
Ran unit tests inside Docker (
golang:1.26-bookworm):go test -v ./pkg/apis/deployment/...Output:
Fixes #1978.