Repository navigation
feat: save the storage file on a background thread by default - #89
Merged
Merged
Conversation
…riter abstraction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving no longer blocks the caller until the data is on disk. Changes are still serialized on the calling thread, and only the file write is handed over to a shared background thread, one storage at a time. A newer change replaces an unwritten older one, since the file is always written whole and only the last state matters.
Save()keeps its meaning and blocks until the data has actually reached the disk, and disposing a storage flushes whatever is still pending. PassSaveOnBackgroundThread(false)to the builder to get the previous behaviour, where every change writes the file before returning.The trade-off is that a change now reaches the disk a moment after the call returns instead of during it. Publication stays atomic, so a process killed inside that window keeps the previous generation intact and loses only the last change.