Repository navigation
refactor: drop the storage finalizer - #92
Merged
Merged
Conversation
BinaryStorage holds no unmanaged resources, so the finalizer had nothing to release. It skipped the save, disposed collections that were already unreachable, and released the editor path lock by mutating a static HashSet from the finalizer thread while the main thread could be reading it from Construct. With the finalizer gone, disposing is the only path, so Dispose no longer needs the disposing flag or the two branches it guarded.
imurashka
force-pushed
the
ivan/drop-storage-finalizer
branch
from
October 6, 2026 10:44
ede71b1 to
6a58b63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BinaryStorageholds no unmanaged resources, so its finalizer had nothing to release: it never saved anything, and on the finalizer thread it only released the editor path lock by changing a static set the main thread could be reading at the same time. With the finalizer gone,Dispose(bool)folds back intoDispose().A storage that is never disposed now keeps its editor path lock until the domain reloads. Nothing changes for storages that are disposed.