Repository navigation
fix: keep the change when a storage write fails - #97
Merged
Merged
Conversation
imurashka
force-pushed
the
ivan/keep-change-after-failed-save
branch
from
October 6, 2026 11:05
a89d387 to
93601e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The storage marked itself saved before the write, and the background writer only logged a failed write. So after a failed write, for example `File.Replace` while another process holds the backup file, `Dispose()` found nothing to save and the last change never reached the disk.
Now a failed write, on the background thread or on the calling one, leaves the storage counted as changed, and the next change, `Save()` or `Dispose()` writes the data again. The writer does not retry on its own.