Repository navigation
Move Arcaea Offline Database to :shared module - #78
Merged
Merged
Conversation
* First step of the database package relocation from :core into shared commonMain: room3 runtime, bundled SQLite driver and kotlinx-datetime for commonMain, room3 compiler via KSP for the android and jvm targets
* The room3 database now compiles for the android and desktop targets; schemas move with it because AutoMigration codegen validates against the module-local schema directory * The common factory builds from a caller-provided builder and holds no global state; the cached singleton stays in androidMain * Desktop resolves the location via FileKit.databasesDir and a future location picker can override it via FileKit.init
* DatabaseMigrationsTest and the DAO/repository tests now run on the host JVM via the bundled driver; the instrumented Context builders are replaced with the common no-context builder, and the 7→8 seed script drops its android_metadata statement which the bundled driver does not create
* Importer tests moved to :shared jvmTest
283375
changed the title
:shared module:shared module
283375
marked this pull request as ready for review
October 15, 2026 02:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39.
Part of #24.