Repository navigation
Conversation
…kip unmarked heading degrees Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ache scale brush Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…textures for video and icons Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The netstandard2.0 build of MissionPlanner.Controls (Android/Mac) compiles HUD.cs against the stub GL class in netstandard2.0/Shim.cs instead of OpenTK. The batched drawing path uses buffer objects, the IntPtr forms of the client-array pointers, GenTexture, TexImage2D with a managed array and the TextureEnvMode enum, none of which the stub had, so every CI build failed with CS0117/CS0103/CS1503 in HUD.cs. Add those members and enums to the shim, throwing NotImplementedException like the rest of it; the GL path is never taken on those platforms. Built MissionPlanner.Controls for both net472 and netstandard2.0. Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com>
Collaborator
Author
|
Notes from a review pass. The diff reads correctly and CI is green, but the description says it hasn't been run yet, so this should be held until the manual test list has been done on both GL and GDI. Open questions:
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Not built or run yet. To check on a Windows build with SITL:
HUD <n> hz drawtime <ms> gl <bool>console line before and after🤖 Generated with Claude Code