Skip to content

[Contract] — Staking Vault Early Unlock Penalty #2035

Closed

Description

@Olowodarey

Problem
lock.rs/fees.rs early-unlock penalty (if offered) may be miscomputed or bypassable.

Requirements

  • Apply the documented early-unlock penalty when permitted, with checked math.
  • Route the penalty per policy and reject bypass attempts.
  • Tests:
    • an early unlock applies the correct penalty
    • a normal unlock after lock applies no penalty
    • the penalty cannot be bypassed

Acceptance Criteria
Early-unlock penalties are correct. Covered by tests.

Files

  • contracts/staking-vault/src/lock.rs
  • contracts/staking-vault/src/fees.rs

Activity

  1. Peace-001 commented on Oct 16, 2026

    @Peace-001

    @Peace-001 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Good day maintainer i would like to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Peace-001 to this issue.

  2. drips-wave commented on Oct 16, 2026

    @drips-wave

    Congratulations, @Peace-001! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @Peace-001: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  3. grantfox-oss commented on Oct 20, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @Peace-001's PR #2061 was approved and merged by @Olowodarey.

    🏆 @Peace-001: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (433 total points). Track your full progress on GrantFox.

    👏 Great work, @Peace-001! Keep contributing to Arena1X.

  4. drips-wave commented on Oct 20, 2026

    @drips-wave

    This issue has been completed by @Peace-001 as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @Peace-001: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

  5. added a commit that references this issue on Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions