improved implementation of outlines#681
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ryfactor
approved these changes
Jun 17, 2026
ryfactor
left a comment
ryfactor
left a comment
Member
There was a problem hiding this comment.
This is a welcome fix to a longstanding issue, thank you @zenorogue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed that IVAN includes an option to use my boundary mod.
However, it was done by having copies of files (such as
Graphics/Item-outlined.png) and using them at startup instead of the correct ones. These files were very old and do not include some new stuff added since then (so presumably some graphics would be missing).This change makes IVAN instead automatically edit the affected files to add the boundaries. I have also changed it so that no restart is required when switching this option.
Note: to work correctly, I had to hardcode the coordinates of large entities; so
igraph.cppwill still need to be changed if any new large or otherwise non-conforming graphics are added. I tried to take them automatically from the data instead, but it does not seem possible due to how IVAN is structured -- some coordinates are hardcoded in various cpp files.