Clarify same-side reward-boundary ordering in escalation tests#419
Open
KillariDev wants to merge 3 commits into
Open
Clarify same-side reward-boundary ordering in escalation tests#419KillariDev wants to merge 3 commits into
KillariDev wants to merge 3 commits into
Conversation
- Update escalation and vault accounting test names to specify first-come/append-order safety-boundary behavior. - Add comments documenting that bonus-reward slices are consumed by earliest winning deposits on the same side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
solidity/ts/tests/escalationGame.test.tsto document that deposits on the same side consume reward windows in append order.solidity/ts/tests/peripherals/vaultAccounting.test.tsto capture the intended behavior when multiple winners on one side deposit in sequence.Testing