Skip to content

Refactor security pool and fork workflows with clearer validation, coordinator execution, and escrow partitioning tests#426

Merged
KillariDev merged 2 commits into
mainfrom
t3code/4761a5ad
Jul 1, 2026
Merged

Refactor security pool and fork workflows with clearer validation, coordinator execution, and escrow partitioning tests#426
KillariDev merged 2 commits into
mainfrom
t3code/4761a5ad

Conversation

@KillariDev

Copy link
Copy Markdown
Collaborator

Summary

  • Updated mainnet deployment addresses in docs/mainnet-deployment-addresses.json and docs/mainnet-deployment-addresses.md to reflect the latest deterministic deployment set and derived contract addresses.
  • Refactored SecurityPool validation logic into explicit helper checks for collateral coverage, minimum thresholds, and allowance/risk guards, preserving behavior while improving readability and reuse.
  • Reworked staged oracle operation execution in SecurityPoolOracleCoordinator into dedicated helper paths with named error constants and clearer event/error semantics (ui and solidity behavior unchanged in intent, but execution flow is now easier to follow and test).
  • Refactored forker delegation in SecurityPoolForker to pass explicit calldata into private delegation helpers, reducing ambiguous fallback-style behavior and enabling clearer external function routing.
  • Added explicit FIFO/time-priority semantics comment for same-tick auction fills in UniformPriceDualCapBatchAuction to document matching behavior.
  • Expanded and adjusted peripheral + workflow tests: added own-fork claim/unresolved-migration partition test coverage, extracted reusable truth auction scenario helpers, and updated workflow/test fixture/builders to match refactored flow and selection/state hooks.
  • Updated UI-related security pool workflow/read-state hooks and auction/fork interaction state wiring to align with the refactored contract interaction model.

Testing

  • Not run in this response.
  • Suggested checks: bun run tsc, bun run check, bun run knip, bun run test

- update mainnet deployment addresses in docs to latest deterministic outputs
- extract shared truth-auction setup logic into reusable test helpers
- refactor SecurityPool and SecurityPoolOracleCoordinator to centralize checks and clearer staged-operation error handling
- add UI fork-auction/workflow interaction state hooks and improve security pool orchestration test coverage
# Conflicts:
#	docs/mainnet-deployment-addresses.json
#	docs/mainnet-deployment-addresses.md
#	ui/ts/components/ForkAuctionSection.tsx
#	ui/ts/contracts.ts
@KillariDev KillariDev merged commit 56cfa10 into main Jul 1, 2026
1 check passed
@KillariDev KillariDev deleted the t3code/4761a5ad branch July 1, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant