Refactor security pool and fork workflows with clearer validation, coordinator execution, and escrow partitioning tests#426
Merged
Merged
Conversation
- update mainnet deployment addresses in docs to latest deterministic outputs - extract shared truth-auction setup logic into reusable test helpers - refactor SecurityPool and SecurityPoolOracleCoordinator to centralize checks and clearer staged-operation error handling - add UI fork-auction/workflow interaction state hooks and improve security pool orchestration test coverage
# Conflicts: # docs/mainnet-deployment-addresses.json # docs/mainnet-deployment-addresses.md # ui/ts/components/ForkAuctionSection.tsx # ui/ts/contracts.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/mainnet-deployment-addresses.jsonanddocs/mainnet-deployment-addresses.mdto reflect the latest deterministic deployment set and derived contract addresses.SecurityPoolvalidation logic into explicit helper checks for collateral coverage, minimum thresholds, and allowance/risk guards, preserving behavior while improving readability and reuse.SecurityPoolOracleCoordinatorinto dedicated helper paths with named error constants and clearer event/error semantics (uiandsoliditybehavior unchanged in intent, but execution flow is now easier to follow and test).SecurityPoolForkerto pass explicit calldata into private delegation helpers, reducing ambiguous fallback-style behavior and enabling clearer external function routing.UniformPriceDualCapBatchAuctionto document matching behavior.Testing
bun run tsc,bun run check,bun run knip,bun run test