Clarify truth-auction debt exposure messaging for bids and settlement#429
Merged
Conversation
- Add auctioned bond allowance visibility in auction/settlement UI and summary card metrics - Update action-safety and confirmation copy for bid submission and claim settlement - Adjust fork auction stage copy and success presentation to describe REP + debt transfer - Add/extend tests for open-interest debt messaging and claim confirmation behavior
# Conflicts: # ui/ts/components/ForkAuctionSection.tsx
- Add explicit finalized refund-only settlement action path in fork auction settlement logic and UI state - Update settlement action safety IDs/prompts and labels for refund-only finalized bids - Add auctioned bond allowance label constant and reuse for copy, metrics, and warnings - Add selection-level settlement preview and improved pending/success titles for mixed/ refund settlements - Extend tests and action-state/contracts typing to cover new settlement mode behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WarningSurfacenotice in bid and settlement flows to reduce confusion around what winning bids claim vs. refunds.Auctioned Bond Allowancedirectly in the auction overview.claimAuctionProceedstransactions.forkAuction,forkAuctionSection,transactionActionButton, andtransactionPresentationsto cover the new messaging and confirmation behavior.Testing
ui/ts/tests/forkAuction.test.ts: added assertion that fork truth-auction description includes open-interest debt language.ui/ts/tests/forkAuctionSection.test.tsx: added explicit UI coverage for bid-stage and settlement-stage debt messaging.ui/ts/tests/transactionActionButton.test.tsx: added confirmation requirement test forclaimAuctionProceeds.ui/ts/tests/transactionPresentations.test.ts: added verification of success detail text for claim settlement.Not run: no repository commands were executed in this response; recommend running project validation commands before merge (targeted tests/typecheck/format/check per AGENTS guidance).