Skip to content

Scope page author stylesheet variants to routes in place - #3548

Open
chubes4 wants to merge 9 commits into
trunkfrom
fix/2755-route-scoped-variants
Open

chubes4 wants to merge 9 commits into
trunkfrom
fix/2755-route-scoped-variants

Conversation

@chubes4

@chubes4 chubes4 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The virtual base route forced private page-marker variants into costly route scopes. Shared template-part markup now supplies conservative carrier evidence, allowing private variants to remain unscoped without weakening render-time state or non-plan page correctness.

What changed

  • Pass shared template-part candidates into virtual-base and plan-route inertness proofs.
  • Recognize required page-local classes in selector subjects and ancestors using token/carrier checks.
  • Keep plain arms and render-time route-state selectors scoped when required.
  • Extend the existing scaling contract for private markers, shared-header carriers, and roughly constant site-wide stylesheet size.
  • Additive. Route hooks, stylesheet byte budgets, fallback policy, and no-route-class base behavior remain unchanged.

Verification

  • cd php-transformer && php tests/unit/css-stylesheet-transformer.php passed on d2ffcec. Base trunk@e0393f3 advanced to 3f37b9d.

  • cd php-transformer && php tests/contract/shared-author-stylesheet-scaling.php passed on d2ffcec. Base trunk@e0393f3 advanced to 3f37b9d.

  • cd php-transformer && php tests/unit/document-root-font-ownership.php passed on d2ffcec. Base trunk@e0393f3 advanced to 3f37b9d.

  • cd php-transformer && composer test:canonical passed on d2ffcec. Base trunk@e0393f3 advanced to 3f37b9d.

  • cd php-transformer && composer lint passed on d2ffcec. Base trunk@e0393f3 advanced to 3f37b9d.

  • CI: pending

Cook run
  • Gate 1: tree ba2b73003db03c7851af69a0a4068b952a69d1b3, fingerprint e4d86c46c58f0ee9c8bf926ba199dbd47f178ee713f7d13b699358a4876e8fbc
  • Gate 2: tree ba2b73003db03c7851af69a0a4068b952a69d1b3, fingerprint e4d86c46c58f0ee9c8bf926ba199dbd47f178ee713f7d13b699358a4876e8fbc
  • Gate 3: tree ba2b73003db03c7851af69a0a4068b952a69d1b3, fingerprint e4d86c46c58f0ee9c8bf926ba199dbd47f178ee713f7d13b699358a4876e8fbc
  • Gate 4: tree ba2b73003db03c7851af69a0a4068b952a69d1b3, fingerprint e4d86c46c58f0ee9c8bf926ba199dbd47f178ee713f7d13b699358a4876e8fbc
  • Gate 5: tree ba2b73003db03c7851af69a0a4068b952a69d1b3, fingerprint e4d86c46c58f0ee9c8bf926ba199dbd47f178ee713f7d13b699358a4876e8fbc
  • Publication identity: ambient_gh

AI assistance

Tool: Homeboy (pi) · Model: gpt-6.1-sol (tier roadie/cook-heavy) · Used for: AI inspected the PR and linked design discussion, implemented carrier-based proofs, extended regression coverage, and ran all required gates.

Relates to #3548

@chubes4
chubes4 force-pushed the fix/2755-route-scoped-variants branch from 61cbf72 to 37cba59 Compare October 26, 2026 23:42
@chubes4
chubes4 force-pushed the fix/2755-route-scoped-variants branch from 6fa3e21 to ff5af83 Compare October 27, 2026 02:39
@chubes4
chubes4 marked this pull request as ready for review October 27, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant