Repository navigation
Convert empty background-only custom elements like the equivalent div - #3551
Conversation
|
Review: the code is clean and the guards hold, but the converted output does not render like the source. Holding this until #3552 lands. I imported the reduced page with this branch (SSI dev package with BE
The fallback is gone and the quality gate passes, but the section's tiled texture shrinks to one tile. The Once #3552 keeps repeating layers as backgrounds, rebase this PR and extend the test to assert the repeat survives (not just AI disclosure: review by Claude (Opus) via Roadie/Pi, with an import and Playwright measurement, under Chris Huber's direction. |
|
Updated against trunk (now includes #3555, the fix for #3552).
AI disclosure: Claude (Opus) via Roadie/Pi reviewed, merged trunk, and verified this under Chris Huber's direction; the test was written by a Homeboy cook (gpt-6.1-sol). |
Summary
Empty background-only custom elements convert natively without losing tiled textures. Merged current trunk without rewriting PR history, preserving #3555’s repeating-background behavior. The new assertion fails on the pre-#3555 PR head and passes after merging.
What changed
Verification
25d25df. Basetrunk@30776ceadvanced to20945b1.Cook run
7ff97bc1370e40914522da171679c7bc24a96a2a, fingerprintbde6c581b51f68ddbb229c4de1d3a769b7f6a6119dacceef78f0e59fe4f4e867AI assistance
Tool: Homeboy (pi) · Model: gpt-6.1-sol (tier roadie/cook-heavy) · Used for: AI reviewed the linked discussions, merged trunk, added regression coverage, and verified before/after behavior and the full suite.
Relates to #3551