Repository navigation
Share identical headers whose captured dialog ordinal differs per route - #3553
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shell extraction refused to share a header across routes when the only difference was the capture's ordinal dialog panel handle (
data-blocks-engine-capture-dialog-Nin the panel id, the panel attribute and the trigger'saria-controls). Shell identity now ignores that ordinal in the same normalization that #2960 added for the projector's hashed dialog id, so such headers become one shared header template part. Before: the 3-page fixture's diagnostic listed only[{"area":"footer","slug":"footer"}]. After: a header part (3/3) and a footer part, withpageandfront-pageincluding both.What changed
normalizeNestedChromeMarkup()inShellExtraction.phpmapsdata-blocks-engine-capture-dialog-<N>to the bare handle for identity only, so the id and every reference to it normalize the same way. It usesCaptureEvidence::DIALOG_CLASSrather than spelling out the name.tests/unit/captured-dialog-ordinal-shared-header.php(registered in composer.json) uses the issue's 3-page fixture. It checks that the header and footer parts are shared and that page/front-page include both, plus a negative control: headers whose dialogs differ in content stay unshared.Verification
b7585ca. Basetrunk@4f62f31unchanged.Cook run
0dfaf5720227da8e0551e2b6801a333df690df9c, fingerprintdd6dfeca89aecb9eef915019bb3abf5b615a71f72597b42fabbc82ded983d239AI assistance
Tool: Homeboy (pi) · Model: claude-opus-5-5 (tier roadie/cook-heavy) · Used for: The AI read the existing #2960 normalization, wrote the reduced-fixture regression test with a negative control, applied a one-line normalization fix, and ran the php-transformer suite.
Closes #3549