Skip to content

feat(Clipboard-Bar-Hist): Add search/filter to saved clipboard entries + fix for current search#2464

Open
Bodify wants to merge 4 commits into
AvengeMedia:masterfrom
Bodify:feature/clipboard-list-tweaks
Open

feat(Clipboard-Bar-Hist): Add search/filter to saved clipboard entries + fix for current search#2464
Bodify wants to merge 4 commits into
AvengeMedia:masterfrom
Bodify:feature/clipboard-list-tweaks

Conversation

@Bodify
Copy link
Copy Markdown
Contributor

@Bodify Bodify commented May 21, 2026

DankBar: Enable searching in saved clipboard entries and changes the popup title between "Clipboard History" and "Clipboard Saved" when toggling the Saved/Recent button.

Also fixes search/filter issues for DankBar's Clipboard History similar to #2315

Copy link
Copy Markdown
Collaborator

@Purian23 Purian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I tested search on saved/pinned entries and it works great. The ClipboardService filter fix and tab-specific header count look good to me.

Couple of small items:

Please revert the manual en.json changes. That file is auto-generated on its own.

Let's drop the add/remove/displaced/move: null changes, they were intentional. I actually like the list animating while filtering, it feels nicer than an instant snap.

Happy to approve once those are addressed, we appreciate it.

@Bodify Bodify force-pushed the feature/clipboard-list-tweaks branch from 14e35cc to a06944a Compare May 30, 2026 12:27
…s as well. Change title on toggle between recent/saved.
@Bodify Bodify force-pushed the feature/clipboard-list-tweaks branch from a06944a to 8dc265b Compare May 30, 2026 12:30
@Bodify
Copy link
Copy Markdown
Contributor Author

Bodify commented May 30, 2026

Please revert the manual en.json changes. That file is auto-generated on its own.

Done, my bad.

Let's drop the add/remove/displaced/move: null changes, they were intentional. I actually like the list animating while filtering, it feels nicer than an instant snap.

I wouldn't mind some short animations but I can't even say I notice them the way it is now? I only notice the bugs. I'm not entirely sure what the root cause behind it is but keeping the transitions messes everything up same as in #2315. Removing them fixes it. It will probably require a fix elsewhere that is out of my comfort zone and revert the mentioned PR after a proper fix is in place.

This is what happens for me if I don't null the animations:

filterBug.mp4

@Bodify
Copy link
Copy Markdown
Contributor Author

Bodify commented May 30, 2026

I also made the Pinned/Saved icon stay highlighted when selected to make it more consistent and obvious.

Let me know if I should remove the animation nulls or not or what happens there.

@Bodify
Copy link
Copy Markdown
Contributor Author

Bodify commented May 30, 2026

After digging a bit more I found the reason: I have Animation Duration set to None/0ms in the Typography & Motion settings. It doesn't like that.

I'm not sure of the best way fix to this? I removed the nulling of the animations but it will require a fix for people with None/0ms animations set. That fix is then likely also wanted for this previous change in #2315

@Bodify Bodify requested a review from Purian23 May 30, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants