fix: port reusable network-teardown action to v5-next#24252
Open
PhilWindle wants to merge 1 commit into
Open
Conversation
(cherry picked from commit ef43cb7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cherry-picks
ef43cb7fa20("ci: reusable network-teardown action that runs on GitHub runners") fromnextonto the v5 line.This is a clean port —
.github/actions/network-teardown/action.ymlis byte-identical tonext, and the three workflow files (nightly-bench-10tps.yml,nightly-spartan-bench.yml,test-network-scenarios.yml) get the same teardown-refactor hunks applied on top of their v5-specific config.Why
The nightly Spartan Benchmarks run on the private repo's default branch (
next), whosecleanup-*jobs were refactored on 2026-06-17 to call the local composite action:The checkout pins
source_ref(the nightly tag). When the deployed tag is a v5 nightly tag, that tree did not contain.github/actions/network-teardown(the action was only ever on thenextline), so cleanup failed with:This left network resources orphaned on every failure (observed in nightly run #95). Porting the action to
v5-nextmeans future v5 nightly tags include it, so the cleanup checkout resolves the action correctly.weekly-proving-bench.ymlandci3.ymlkeep the olderci3.sh network-teardownform — matchingnextexactly (the original commit did not touch them).Routing
Targets
v5-nextdirectly (not viamerge-train/spartan-v5) since the commit already exists onnext; routing through the merge train would attempt a redundant port back to privatenext. This PR syncs to privatev5-next.