Repository navigation
{Compute} Update test case and add recording for FlexProfile feature - #34265
William (william051200) wants to merge 1 commit into
Conversation
X Engineering Agent ReportReview — Comments No confirmed test-strength or scope-consistency findings at The changes enable playback for the two FlexProfile scenarios with East Asia/v6 fixtures and stay within the stated tests-only scope. Inspected author recordings align with the assertions for preferred-size updates, tag preservation, opt-in/out, and conflicting-size rejection. Recorded requests distinguish flexible creation from fixed-size creation and omit the profile on opt-out. The supplied upstream CI snapshot reports 54/54 successful checks. Author recordings are separate evidence, not Agent live testing; static inspection does not establish playback request-body matching or verify current live behavior. Test validation
Risk assessment — 10/100 · LowThe Low rating reflects the detected change scope with no elevated security, reliability, customer, operational, dependency, sovereign-cloud, generated-output, or cross-component signal.
Posted by x-engineering-agent (Reviewer) |
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in the scoped test changes or recording alignment; tests were not executed.
No open issues 🎉
What changed in this PR
This PR adds playback coverage for the VM FlexProfile support introduced in #34231, without changing production command behavior.
Changes:
- Removes live-only restrictions from both FlexProfile scenarios.
- Updates the scenarios to use East Asia and Dsv6 VM sizes.
- Adds a recording for FlexProfile creation, preferred-size updates, and show/list verification.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py | Enables playback and updates region and size inputs for both scenarios. |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_vm_flex_profile_create_and_update.yaml | Records the FlexProfile create-and-update scenario. |
Review effort: Balanced
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
William (@william051200) Ready for human review. See the X Engineering Agent Report.
🤖 PR Validation — ️✔️ All clear
Related command
Description
Update test case and add recording for flex profile feature from #34231
Testing Guide
2 test cases
test_vm_flex_profile_create_and_updateandtest_vm_flex_profile_opt_in_opt_outHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.