Skip to content

{Compute} Update test case and add recording for FlexProfile feature - #34265

Open
William (william051200) wants to merge 1 commit into
Azure:devfrom
william051200:flex-profile-test
Open

William (william051200) wants to merge 1 commit into
Azure:devfrom
william051200:flex-profile-test

Conversation

@william051200

@william051200 William (william051200) commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

🤖 PR Validation — ️✔️ All clear

Breaking Changes Tests
️✔️ None ️✔️ 130/130

Related command

Description

Update test case and add recording for flex profile feature from #34231

Testing Guide

2 test cases test_vm_flex_profile_create_and_update and test_vm_flex_profile_opt_in_opt_out

History Notes


This checklist is used to make sure that common guidelines for a pull request are followed.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 03:58
@william051200 William (william051200) added the Request X Engineering Agent Ask the agent to triage this issue or review this PR label Oct 23, 2026
@x-engineering-agent

x-engineering-agent Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

X Engineering Agent Report

Review — Comments

William (@william051200)

No confirmed test-strength or scope-consistency findings at bdb785f88419c06cf35441e8c63db795ecbb3f39.

The changes enable playback for the two FlexProfile scenarios with East Asia/v6 fixtures and stay within the stated tests-only scope. Inspected author recordings align with the assertions for preferred-size updates, tag preservation, opt-in/out, and conflicting-size rejection. Recorded requests distinguish flexible creation from fixed-size creation and omit the profile on opt-out.

The supplied upstream CI snapshot reports 54/54 successful checks. Author recordings are separate evidence, not Agent live testing; static inspection does not establish playback request-body matching or verify current live behavior.

Test validation
  • Agent live test: Not run; this is a review-only PR. Check author-provided test evidence and upstream CI separately.
  • Regression coverage: Not applicable to the changed files.
Risk assessment — 10/100 · Low

The Low rating reflects the detected change scope with no elevated security, reliability, customer, operational, dependency, sovereign-cloud, generated-output, or cross-component signal.

  • Change scope: 3 changed files, 3735 changed lines (+3723 / -12), including 0 production files.
  • Affected components: No production component was identified.
  • Risk drivers: No elevated risk signal was detected.
  • Regression evidence: No production-code regression-test signal applies.
  • Confidence: Low because no production changed-line evidence was available.
  • Required review: No additional owning-squad review signal was detected.

Posted by x-engineering-agent (Reviewer)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Static review found no blocking issues in the scoped test changes or recording alignment; tests were not executed.

No open issues 🎉

What changed in this PR

This PR adds playback coverage for the VM FlexProfile support introduced in #34231, without changing production command behavior.

Changes:

  • Removes live-only restrictions from both FlexProfile scenarios.
  • Updates the scenarios to use East Asia and Dsv6 VM sizes.
  • Adds a recording for FlexProfile creation, preferred-size updates, and show/list verification.
File Description
src/​azure-cli/​azure/​cli/​command_modules/​vm/​tests/​latest/​test_vm_commands.py Enables playback and updates region and size inputs for both scenarios.
src/​azure-cli/​azure/​cli/​command_modules/​vm/​tests/​latest/​recordings/​test_vm_flex_profile_create_and_update.yaml Records the FlexProfile create-and-update scenario.

Review effort: Balanced

@yonzhan

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

@x-engineering-agent x-engineering-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

William (@william051200) Ready for human review. See the X Engineering Agent Report.

@x-engineering-agent x-engineering-agent Bot added X Engineering Agent Reviewed Agent reviewed this PR and removed Request X Engineering Agent Ask the agent to triage this issue or review this PR labels Oct 23, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

X Engineering Agent Reviewed Agent reviewed this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants