[Jean Kim (kestry)]

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes	Tests	Suppressions
️✔️ None	️✔️ 130/130	⚠️ 1 added

This PR adds warning or check suppressions. Fix the underlying warning where possible and justify each remaining suppression in a code comment or the PR description.

1 added suppression

File	Line	Kind	Code
src/azure-cli-testsdk/azure/cli/testsdk/patches.py	94	pylint	def _yield_to_polling_thread(*args, **kwargs): # pylint: disable=unused-argument

Related command

Shared azure-cli-testsdk scenario playback for commands that wait for background pollers; not specific to one command module.

Description

Problem:
Currently, playback replaces both ARM service polling delays and the CLI foreground completion-check delay with no-ops. However, the foreground loop can consequently spin while a background poller is trying to make progress. This caused high CPU utilization and led playback to run near as long as the live recording. (54min live, 41min playback).

Local testing showed 9.9 million polls in ~57 seconds.

Solution:
Keep the ARM service delay as a no-op, but replace the foreground playback delay with threading.Event.wait(0.001). This requests a short real wait and yields to the background poller even when playback has patched time.sleep to a no-op. Existing test cleanup restores both delay methods.

Local test results:

Measurement	Before	After
Local poller.done() checks	9,902,094	20
Test-body duration	~57 seconds	6.24 seconds

Playback down from 41min to 40sec:

Additional info:
Added regression coverage for both replay-hook orders, the no-op service delay versus the requested 1 ms foreground wait, cleanup, playback-only registration, completion, and exception propagation. Documented the behavior in the test SDK README.

This change is limited to four test SDK files. It does not change production/core polling, live execution, recordings, package versions, or Edge Action-specific behavior.

Testing Guide

Run from the repository root using the existing development environment. AZURE_TEST_RUN_LIVE must be unset; setting it to a nonempty string such as false is not equivalent.

Remove-Item Env:AZURE_TEST_RUN_LIVE -ErrorAction SilentlyContinue
$env:PYTEST_DISABLE_PLUGIN_AUTOLOAD='1'
& 'C:\wcodebase\repos\azure-cli-extensions\.venv\Scripts\python.exe' -m pytest 'src\azure-cli-testsdk\azure\cli\testsdk\scenario_tests\tests' 'src\azure-cli-testsdk\azure\cli\testsdk\tests' -q --disable-warnings

Result: passed, 21 tests and 4 subtests, with 4 warnings, in 1.82 s.

& 'C:\wcodebase\repos\azure-cli-extensions\.venv\Scripts\python.exe' -m flake8 --exclude='' 'src\azure-cli-testsdk\azure\cli\testsdk\patches.py' 'src\azure-cli-testsdk\azure\cli\testsdk\tests'

Result: passed.

git diff --check
git diff --cached --check

Result: both passed before committing.

The local pre-commit hook reported that its Python environment was not activated and exited successfully without running its checks; the explicit pytest and flake8 commands above were run separately and passed. No live operations or full Edge Action eight-scenario playback run were performed for this publication.

History Notes

N/A. Test-only change; the {Test SDK} title intentionally excludes a customer-facing history entry.

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.

• I adhere to the Command Guidelines.

• I adhere to the Error Handling Guidelines.

[azure-pipelines]

Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

🟢 Approval recommended

No active review issues remain for the playback polling-delay change.

No open issues 🎉

What changed in this PR

This PR prevents busy looping in shared test SDK playback by giving background pollers time to progress. Production polling and live execution remain unchanged.

Changes:

• Replace the foreground playback delay with threading.Event.wait(0.001), while keeping ARM service delays disabled.
• Add regression tests for patch order, delay behavior, cleanup, playback-only registration, completion, and exception propagation.
• Document playback polling behavior.

File	Description
src/​azure-cli-testsdk/​README.rst	Document playback delays and cleanup behavior.
src/​azure-cli-testsdk/​azure/​cli/​testsdk/​tests/​test_patches.py	Add regression coverage for polling delay patches.
src/​azure-cli-testsdk/​azure/​cli/​testsdk/​tests/​__init__.py	Initialize the test package.
src/​azure-cli-testsdk/​azure/​cli/​testsdk/​patches.py	Add a short foreground wait independent of patched time.sleep.

_{Review effort: Balanced}

[Aditya Pujara (a0x1ab)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).

[Aditya Pujara (a0x1ab)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).

[Ethan Yang (necusjz)]

better to move the tests under azure/cli/testsdk/scenario_tests/tests.

[Aditya Pujara (a0x1ab)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).