Skip to content

feat(signal): deploy certification runtime - #1026

Open
Kevin Cho (chokevin) wants to merge 1 commit into
chokevin-signal-certification-adapterfrom
chokevin-signal-deployment-layer
Open

Kevin Cho (chokevin) wants to merge 1 commit into
chokevin-signal-certification-adapterfrom
chokevin-signal-deployment-layer

Conversation

@chokevin

@chokevin Kevin Cho (chokevin) commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

The lower Project Signal layers define certification contracts, reconciliation, and participant execution, but they do not package or deploy the runtime. This top stack layer adds the build, image, manifest, RBAC, WorkflowTemplate, and controller Deployment integration needed to run the proven cross-node MPI orchestration path.

Stack

Scope

  • Add namespace, service account, RBAC, fixed participant adapter WorkflowTemplate, and controller Deployment templates under deploy/signal/.
  • Render the Signal templates plus the CRDs supplied by layer 1 through make signal-manifests.
  • Add controller and adapter binary/image targets and Containerfiles.
  • Exclude generated manifests from container build contexts.

Non-goals

Verification

  • Passed: make signal-manifests
  • Passed: make project-signal-controller-build project-signal-adapter-build
  • Passed: go test ./api/signal/... ./cmd/project-signal-controller/... ./cmd/project-signal-adapter/... ./internal/signal/...
  • Passed: local controller and adapter image builds; both loaded and inspected as Linux ARM64 images
  • Passed: git diff --check
  • Passed: exact changed-file boundary check against the 12 assigned paths
  • Repository-wide go test ./... was run, but cannot pass on this macOS host because existing Linux-specific packages reference unavailable unix APIs and unrelated host-sensitive symlink tests fail. The Signal-specific packages above pass.

Review guide

  1. Start with the signal-manifests and image targets in Makefile.
  2. Review deploy/signal/04-adapter-workflowtemplate.yaml.tmpl and 06-deployment.yaml.tmpl for the fixed orchestration and immutable image wiring.
  3. Check RBAC in 02-rbac.yaml.tmpl and 03-adapter-serviceaccount-rbac.yaml.tmpl against the controller and adapter responsibilities.
  4. Confirm the runner remains an external image input rather than duplicated implementation.

Evidence

A 15-second recording shows the specific deployment/config diff, rendered manifest wiring, and successful build behavior. Detailed command logs are intentionally kept separate.

AI assistance: GitHub Copilot helped carve the assigned files, reconcile shared build wiring, run validation, create the evidence recording, and draft this description. The claims and final text were verified against the branch diff and command output.

signal-deployment-layer.mp4

@chokevin
Kevin Cho (chokevin) requested a review from a team as a code owner October 29, 2026 20:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant