Repository navigation
Conversation
…t in the assembly content
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #563
Makes the
AssemblyResolverreusable by other UIs so thatRevit_UIcan stop front-loading all its assemblies, and keeps it working with the newBHoM_Engineserialiser. Grasshopper and Excel behaviour is unchanged apart from the points below.AssemblyResolvercan be inherited and extended at run time; its maps are built fromIEnumerable<CodeElementRecord>and the helpers live inUI_Engine.AssemblyContent_<UIName>.tsv) instead of a shared one, so a UI that cannot reflect part of an assembly cannot leave gaps for the others.Initialisationinto the AssemblyResolver and reusable methods in UI_Engine.GetInfoCaller" warning.Each commit is actually fairly simple (except maybe the first one) but it can be quite hard to decipher due the amount of code that is moved around. Here's a document that should hopefully help better understand the changes when going through each commit:
46_BHoM_UI_PR_Summary.md.
Test files
Not applicable. Checked by hand on Rhino 7, Rhino 8 and Excel (first and second start, with and without content file) and on Revit through the
Revit_UIPR.Changelog
AssemblyResolvercan be inherited and extended more easily.AssemblyContent_<UIName>.tsv); the first start after the update rebuilds it (slower once).UI_Engine:RefreshAssemblyContent,ReadCodeElementsFromFile,Merge,ExtensionMethodDictionary,TypeKey,AssemblyNamesInType;LoadNewAssembliesandCodeElementstake an assembly name filter.Additional comments