Repository navigation
Conversation
qixuancao
marked this pull request as ready for review
November 6, 2026 11:11
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Account managers identify accounts either by email address (e.g. Science United) or by user name (e.g. BAM!), as indicated by uses_username in their project config. The "Use account manager" screen always asked for "User:". Retrieve the project config of the entered account manager URL and ask for "Email address:" or "User name:" accordingly, with a matching input type and error message. Keep the previous "User:" label while the config is unknown or could not be retrieved. Refs: BOINC#5388 Assisted-by: Antigravity:Gemini-4-Argon
qixuancao
force-pushed
the
fix/issue-5388
branch
from
November 6, 2026 11:34
9594213 to
2167f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Use account manager" screen always asked for
User:, although account managers identify accounts either by email address (e.g. Science United) or by user name (e.g. BAM!). This is indicated byuses_usernamein the account manager'sget_project_configreply, which the desktop Manager already honours.Change
monitor.getProjectConfigPolling(url)and adapts the account identifier field once the reply matches the current URL:Email address:with an email keyboard if the account manager identifies accounts by email address,User name:if it setsuses_username,User:while the config is being fetched or if it could not be retrieved.acct_mgr_rpcrequest does not change.attachproject_acctmgr_header_usernameadded tovaluesandvalues-en(required byvalidate_android_translations.py).Email address:reuses the already translatedattachproject_login_header_id_email. Other translations are not modified.uses_usernamewas already parsed intoProjectConfig.usesName, so the parser does not change.Testing
AccountIdentifierInputTest(config missing or failed, email-based, user-name-based)../gradlew testDebugUnitTest assembleReleasepasses.python ci_tools/validate_android_translations.pypasses, and so doesgit diff --check.Fixes #5388
Summary by cubic
Fixes the "Use account manager" screen so it asks for the account identifier the selected account manager actually uses. The screen always asked for
User:, but some account managers identify accounts by email address (e.g. Science United) while others use user names (e.g. BAM!).The label now adapts to the account manager's
uses_usernamesetting:Email address:with an email keyboard for email-based managers,User name:for user-name-based ones, and the previousUser:label while the config is fetched or fails. The "missing input" error matches the label. The account manager RPC request is unchanged.Fixes #5388
Written for commit 2167f45. Summary will update on new commits.