Skip to content

Prepare fork-safe CodeQL scanning - #800

Merged
RaananW merged 6 commits into
masterfrom
raananw-website-fork-codeql
Nov 4, 2026
Merged

RaananW merged 6 commits into
masterfrom
raananw-website-fork-codeql

Conversation

@RaananW

@RaananW RaananW commented Nov 3, 2026

Copy link
Copy Markdown
Member

Summary

  • add an advanced CodeQL workflow for static JavaScript/TypeScript and GitHub Actions analysis on master pushes, pull requests, merge groups, weekly schedule, and manual dispatch
  • use the normal pull-request merge revision, minimal job permissions, GitHub-hosted runners, disabled credential persistence/dependency caching, security-extended, and full verified action commit pins
  • document the managed-to-advanced migration, benign fork validation, required-check and code-scanning gate setup, recovery, Dependabot behavior, and future merge-queue verification in .github/CODEQL_MIGRATION.md
  • intentionally omit C# scanning at the user's direction; no application or example source file was deleted or modified

Validation

  • actionlint 1.7.12
  • PyYAML 6.0.3 parsing
  • explicit workflow policy assertions for events, two-language matrix, minimal permissions, forbidden triggers/options, and exact action pins
  • git diff --check

Deployment status and boundaries

Managed CodeQL default setup remains enabled. Advanced uploads cannot coexist with default setup during this transition, so this PR only prepares the reviewed workflow and owner runbook.

The advanced baseline, authorized benign fork-PR scan, required-check execution gate, qualifying-alert threshold gate, Dependabot upload, and merge-queue gate remain unverified until the separately authorized cutover and validation steps in the runbook are completed.

Opening this PR does not authorize repository or organization settings changes, merging, contributor workflow approvals, manual workflow dispatch, test-fork creation, or weakening any existing protection.

RaananW and others added 4 commits November 3, 2026 17:29
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 3, 2026 16:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The migration guide overstates security guarantees because fork PRs can modify the evaluated workflow and inline configuration, and returning contributors may not encounter the stated approval prompt.

1 open issue
What changed in this PR

Prepares advanced CodeQL scanning for fork pull requests without changing application code or activating the managed-to-advanced cutover.

Changes:

  • Adds JavaScript/TypeScript and GitHub Actions analysis for master pushes, pull requests, merge groups, scheduled runs, and manual dispatch.
  • Uses pinned actions, minimal job permissions, static extraction, and disabled credential persistence and dependency caching.
  • Documents owner-authorized migration, validation, merge gates, and recovery; deployment verification remains pending.
File Description
.github/​workflows/​codeql.yml Adds the two-language advanced CodeQL workflow.
.github/​CODEQL_MIGRATION.md Records migration steps, safety properties, validation requirements, and recovery procedures.

Review effort: Balanced

Comment thread .github/CODEQL_MIGRATION.md Resolved
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

RaananW and others added 2 commits November 4, 2026 11:20
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@RaananW
RaananW merged commit fceca4c into master Nov 4, 2026
5 checks passed
@RaananW
RaananW deleted the raananw-website-fork-codeql branch November 4, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants