Fixes dummy pilot handling#2885
Open
DeltaFire15 wants to merge 1 commit into
Open
Conversation
Get in the Hammerhead, Shinji
DeltaFire15
added
Fix
Overmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Did you know that since some point in the past, dummy pilots (AI ships use to not runtime) have been getting dropped somewhere in space instead of being put into their ships?
Did you know that they also have never been refcleaned properly when the ship got destroyed?
Now you do!
This fixes both of those. Thanks Ivan...........
Why It's Good For The Game
Fix man good.
Testing Photographs and Procedure
This was tested for simple cases.
Changelog
🆑
fix: Dummy pilots no longer end up in space and are also properly destroyed on ship destruction.
/:cl: