Use initial scale in double click toggle mode logic#548
Open
Neisvestney wants to merge 1 commit intoBetterTyped:masterfrom
Open
Use initial scale in double click toggle mode logic#548Neisvestney wants to merge 1 commit intoBetterTyped:masterfrom
Neisvestney wants to merge 1 commit intoBetterTyped:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where double-clicking in
togglemode acted likezoomOutwheninitialScalewas set to a non-default value.Details
Previously, in cases where
initialScalewas not1, the toggle mode did not behave as expected — it only zoomed out instead of toggling between zoom states.This change ensures that toggle mode now works correctly in the "Responsive Image" example and other similar scenarios.