Skip to content

Fix panning not working on additionnal window #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qsavoye wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix panning not working on additionnal window #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/core/pan/panning.logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ export function handlePanning(
const paddingValueX = getPaddingValue(contextInstance, sizeX);
const paddingValueY = getPaddingValue(contextInstance, sizeY);

if(clientCoords?.x != clientX && clientCoords?.y != clientY) handleCalculateVelocity(contextInstance, { x, y });
if (clientCoords?.x != clientX && clientCoords?.y != clientY)
handleCalculateVelocity(contextInstance, { x, y });
handleNewPosition(contextInstance, x, y, paddingValueX, paddingValueY);
}

Expand Down
15 changes: 12 additions & 3 deletions src/core/pan/panning.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,18 @@ export const isPanningStartAllowed = (

const target = event.target as HTMLElement;
const targetIsShadowDom = "shadowRoot" in target && "composedPath" in event;

// Helper function to check if an object is an Element (cross-window compatible)
// Using numeric constant 1 (ELEMENT_NODE) instead of Node.ELEMENT_NODE for cross-window compatibility
const isElement = (el: unknown): el is Element => {
return (
el != null && typeof el === "object" && (el as Element).nodeType === 1
);
};

const isWrapperChild = targetIsShadowDom
? event.composedPath().some((el) => {
if (!(el instanceof Element)) {
if (!isElement(el)) {
return false;
}

Expand Down Expand Up @@ -64,7 +73,7 @@ export const handlePanningSetup = (
const y = event.clientY;

contextInstance.startCoords = { x: x - positionX, y: y - positionY };
contextInstance.clientCoords = {x: x, y: y};
contextInstance.clientCoords = { x, y };
};

export const handleTouchPanningSetup = (
Expand All @@ -82,7 +91,7 @@ export const handleTouchPanningSetup = (
const x = touches[0].clientX;
const y = touches[0].clientY;
contextInstance.startCoords = { x: x - positionX, y: y - positionY };
contextInstance.clientCoords = {x: x, y: y};
contextInstance.clientCoords = { x, y };
}
};
export function handlePanToBounds(
Expand Down