[BI-2806] Route Experiments using trialDbId, use trialDbId to get metadata#466
[BI-2806] Route Experiments using trialDbId, use trialDbId to get metadata#466jloux-brapi wants to merge 1 commit into
Conversation
humsika
left a comment
humsika
left a comment
There was a problem hiding this comment.
Everything looks good to me.
| v-if="downloadModalActive" | ||
| v-bind:experiment="downloadExperiment" | ||
| v-bind:modal-title="downloadModalTitle" | ||
| v-bind:trial-id="downloadTrialId" |
There was a problem hiding this comment.
The endpoint GET /experiments/{experimentId}/export was updated to expect trialDbId for experimentId but the table modal still passes in the DeltaBreed UUID so exporting an experiment from the Experiments list download links will result in a not found error.
There was a problem hiding this comment.
Good catch, I think I forgot to test that feature. I will fix this.
|
|
||
| export class ExperimentService { | ||
|
|
||
| static async getSingleExperiment(programId: string, experimentId: string, stats: boolean): Promise<Result<Error, Trial>> { |
There was a problem hiding this comment.
Wonder if we should rename experimentId to trialId in these service and DAO methods to make it more clear which id is expected?
There was a problem hiding this comment.
We could, altho functionally I kind of think they largely mean the same thing as of these changes.
| > | ||
| <b-table-column label="Title" field="name" cell-class="fixed-width-wrapped" sortable v-slot="props" :th-attrs="(column) => ({scope:'col'})" searchable> | ||
| <router-link v-bind:to="{name: 'experiment_dataset', params: {datasetId: getDefaultDataset(props.row.data).id, programId: activeProgram.id, experimentId: BrAPIUtils.getBreedingInsightId(props.row.data.externalReferences,'/trials')}}"> | ||
| <router-link v-bind:to="{name: 'experiment_dataset', params: {datasetId: getDefaultDataset(props.row.data).id, programId: activeProgram.id, experimentId: props.row.data.trialDbId}}"> |
There was a problem hiding this comment.
This will also change the id that is passed to GET /experiments/{experimentId}/collaborators to trialId but existing records in the experiment_program_user_role table will have the deltabreed experiment UUID rather than the trialId stored in experiment_id. It looks like the only records in prod are in a test program so it may not be an issue as any new collaborators would be stored with the trialId. If we did have to do anything, I think it should go in a new card.
5 participants
Description
Story: BI-2806
These changes support the removal of BrAPITrials from the ProgramCache.
The Experiment table will now route experiments using their BrAPITrialDbId, and the metadata grab associated will also use the BrAPITrialDbId.
Dependencies
bi-api PR
Testing
Regression on just about anything Experiment related, including:
Verify there are no log messages related to caching trials for a program by looking at logs once above tests have been completed.
Checklist: