Support GIT_CONFIG_GLOBAL and GIT_CONFIG_SYSTEM env vars#3391
Open
mitre88 wants to merge 1 commit intoBurntSushi:masterfrom
Open
Support GIT_CONFIG_GLOBAL and GIT_CONFIG_SYSTEM env vars#3391mitre88 wants to merge 1 commit intoBurntSushi:masterfrom
mitre88 wants to merge 1 commit intoBurntSushi:masterfrom
Conversation
Implement support for Git 2.32+ environment variables GIT_CONFIG_GLOBAL and GIT_CONFIG_SYSTEM for finding core.excludesFile. These are checked before falling back to traditional paths. Fixes BurntSushi#3275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement support for Git 2.32+ environment variables
GIT_CONFIG_GLOBALandGIT_CONFIG_SYSTEMfor findingcore.excludesFilein the ignore crate.These environment variables are checked before falling back to traditional paths (
~/.gitconfig,$XDG_CONFIG_HOME/git/config).Fixes #3275
Changes
git_config_global_path()function to readGIT_CONFIG_GLOBALenv vargit_config_system_path()function to readGIT_CONFIG_SYSTEMenv varread_gitconfig()helper to read git config filesgitconfig_excludes_path()to check these env vars firstTesting
All existing tests pass.