TextFormField separator removal#170
Conversation
|
Hey @RohanSengupta326! I guess it could be better to reduce and align the underline properly. |
|
how about this? @ItsAdityaKSingh
|
|
Better! Try to move that eye icon away from the underline. It should not look to be in the text field. |
|
That's great! Could you also just push the eye icon up a little so that it comes above the underline horizontal space? |
|
Is this height of the eye icon okay or is more needed? @ItsAdityaKSingh
|
|
LGTM! @nb9960, could you review? |
|
so should send the PR now or wait? @ItsAdityaKSingh |
nb9960
left a comment
nb9960
left a comment
There was a problem hiding this comment.
Why debug.keystore file is introduced?
| ), | ||
| ), | ||
| ), | ||
| separator(), |
There was a problem hiding this comment.
I don't think separator widget is being used anywhere now, can you please remove the widget (wherever it is declared) too
|
debug.keystore and pubspec.lock were changed automatically. |
|
Hey @RohanSengupta326, could you please see PR #175 and discuss the need for separate cards for the fields or have the fields on the same card? You could look at the UI and suggest your ideas there too. |
3 participants
Fixes #158
Describe the changes you have made in this PR -
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.