Feature/Add default value recommendation for install script#229
Merged
Conversation
…variable in install script
mateodurante
force-pushed
the
feature/add_value_in_install_script
branch
from
b6d30f1 to
c8780fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If DJANGO_CORS_ALLOWED_ORIGINS is left empty during the installation, it will cause runtime errors in services like postgres and celery.
This commit defines a safe default (https://127.0.0.1,https://localhost) in ngen.prod.env.example which improves the setup script’s interactive prompt to prevent users from leaving it blank during installation.