Repository navigation
ci: reuse Cacti dependency caches and cover dependency changes - #8246
Merged
TheWitness merged 1 commit intoOct 9, 2026
Merged
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
requested review from
TheWitness
and removed request for
a team
October 9, 2026 12:51
TheWitness
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cookie and CSRF test jobs currently duplicate PHP setup without using Cacti's existing Composer download cache. CSRF and installer path filters also miss changes to their Composer dependencies or shared setup action.
Reuse
.github/actions/setup-php-composerwith the existing locked-tests cache namespace and add the missing dependency paths. Preserve job names, PHP versions, extensions, test commands, coverage settings, permissions, and concurrency groups. This targets develop; the separate 1.2.x cache improvement is included in #8241.The required full PHPStan check exposed three existing undefined-variable errors in the installer CLI helpers. Reuse exactly the two argument guards already present in #8012 and #7790. Offline merges with each PR are conflict-free in both orders and produce identical trees, so either merge order preserves both changes. None of the workflow files modified here is modified by those PRs or the other currently open PRs.
Validation: actionlint 1.7.12 across develop workflows; Cacti's workflow-policy checker; PHP CS Fixer; full PHPStan; all commit hooks; 20 PHP cookie/CSRF tests (166 assertions); 7 JavaScript cookie/CSRF tests; installer numeric-argument and absent-argument smoke checks. PHP checks used PHP 8.5.11 through mise and JavaScript checks used Node 22.22.2. GitHub's PHP-version matrix and Docker integration checks remain necessary before merging.