Repository navigation
fix(docker): restrict development permissions and start the poller - #8453
Merged
TheWitness merged 5 commits intoOct 23, 2026
Merged
Conversation
The web port bound to every interface, named volumes hid the shipped .htaccess denies, and the cron job could neither find php nor write to PID 1's output, so the poller never ran. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
…ig.php check_docker.sh deleted an existing include/config.php on exit, health polling aborted under pipefail before the container reported, the MariaDB wait had no bound, and the BSD mktemp template left its Xs literal. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
requested review from
cigamit
and removed request for
a team
October 22, 2026 21:41
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Deepness sets a zero body margin, so the unhovered #ms-button sits at the viewport origin and headless Chromium on Linux intermittently applies :hover to it. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
changed the title
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
added
bug
|
bmfmancini
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the Docker development stack less exposed and restores its scheduled poller. It binds the web port locally, protects private files and directories, corrects configuration permissions, and launches polling with the proper executable and account. Test helpers also preserve existing configuration and propagate failures, making the stack safer and more useful for development.
Implementation details
Dev-environment hardening for docker-compose.yml and the Docker test scripts.
Verified locally: log/cacti.log, .env, rra files and dotfiles now return 403 while index.php and assets still return 200; cron ran the poller and its output reached docker logs; tests/tools/check_docker.sh passes 29/29 and leaves an existing config.php unchanged.
The CI follow-up includes the three-line Deepness pointer stabilization from #8458 and pulls the integration database from Cacti's authenticated GHCR mirror. The MariaDB digest is unchanged; only the integration job receives
packages: read. This avoids the ECR download-limit failure before tests start.Revision and checks
Verified 2026-10-23 06:07 UTC at
48fcb8d28; targetdevelop, 17 changed files.GitHub reports 43 passed, 4 skipped, 1 neutral, with no failed or pending checks. Skipped and neutral checks are not counted as passed. Earlier local measurements above retain their stated environments and revisions. Independent approval is still required before merge.