Repository navigation
perf(rrd): reuse capability checks within calls - #8512
Draft
somethingwithproof wants to merge 2 commits into
Draft
somethingwithproof wants to merge 2 commits into
somethingwithproof wants to merge 2 commits into
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse RRDtool capability checks within each graph or update call, including negative results. Empty update batches do no version lookup, and the next call starts fresh. No persistent cache is introduced.
This is the lower layer of the native RRDtool stack targeting develop. It carries the implementation and regressions from #8340 on an upstream branch; the original PR stays open with its review history.
Local validation: PHPStan and the repository formatter pass. The combined stack passes 3,158 unit tests with four skips on PHP 8.5.12. Native capability tests also cover graph formatters, ordered updates and acknowledgements. These are local results; the replacement PR's CI must run separately.