Repository navigation
fix(graphs): keep item groups within the selected instance graph - #8528
Open
somethingwithproof wants to merge 1 commit into
Open
somethingwithproof wants to merge 1 commit into
somethingwithproof wants to merge 1 commit into
Conversation
somethingwithproof
requested review from
TheWitness
and removed request for
a team
October 27, 2026 03:41
somethingwithproof
force-pushed
the
fix/graph-group-instance-identity
branch
from
October 27, 2026 19:06
d628b4a to
92268e3
Compare
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
github-actions
Bot
force-pushed
the
fix/graph-group-instance-identity
branch
from
November 1, 2026 09:46
92268e3 to
a046215
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8527.
Graph groups now look up following items by the selected instance graph ID. A parent at sequence 7 in graph 42 therefore keeps graph 42's GPRINT and calculated COMMENT legends, instead of selecting graph 7's items. Template grouping and the hard-return boundary stay covered by the SQL regression fixture.
Validation: the regression fails before the fix and passes after it; 8 coverage-dispatch tests pass; changed PHP coverage is 1/1 executable line (100%). PHP lint, the repository formatter and PHPStan pass.
Hosted checks pass at d628b4a. Maintainer review requested.