Skip to content

refactor(ui): migrate four diagnostic and package lists to Twig - #8547

Draft
somethingwithproof wants to merge 4 commits into
refactor/twig-readonly-pagesfrom
refactor/twig-diagnostic-lists
Draft

somethingwithproof wants to merge 4 commits into
refactor/twig-readonly-pagesfrom
refactor/twig-diagnostic-lists

Conversation

@somethingwithproof

@somethingwithproof somethingwithproof commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Move the User Log, RRD Checker, Public Keys, and Package Repositories list bodies into Twig templates and controllers under src/Controller. Controllers return Symfony HttpFoundation responses and receive rows, validated search text, and realm/type mappings explicitly.

Keep Cacti's query, filter, pagination, sortable-header, authentication, CSRF, edit, and bulk-action paths. The table adapter preserves selection markup and saved column visibility. Database access stays on Cacti's existing db_* helpers. This migration introduces no Doctrine or DBAL.

Validation:

  • The 14 focused Pest cases pass on PHP 8.3.36 and 8.4.25; the completed stack passes 283 UI tests.
  • Five offline Chromium rendering cases pass at this layer; the completed stack covers all ten views.
  • The existing disposable authenticated browser suite passes 54 cases, including all eight list routes with real database queries.
  • Ten request-coverage dispatcher tests pass. The existing browser probe now runs for migrated list entry points so coverage measures the page-to-controller calls as well as the controllers.
  • Repository formatting, PHPStan, staged lint, gettext validation, and commit hooks pass.

Edit and mutation flows retain their existing code and are not covered by the new route checks. GitHub CI is rerunning after the coverage fix.

Targets the Twig foundation branch and depends on its renderer and controller autoloading.

Local changed-line coverage passes the existing gate: 38/38 executable changed PHP lines covered (100.0%). This combines PHP 8.3/Xdebug controller tests with source-hashed coverage from the authenticated browser requests.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
@somethingwithproof
somethingwithproof requested a review from a team as a code owner October 27, 2026 22:25
@somethingwithproof
somethingwithproof requested review from cigamit and removed request for a team October 27, 2026 22:26
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

@somethingwithproof
somethingwithproof marked this pull request as draft October 27, 2026 22:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant