Repository navigation
refactor(ui): migrate four diagnostic and package lists to Twig - #8547
Draft
somethingwithproof wants to merge 4 commits into
Draft
somethingwithproof wants to merge 4 commits into
somethingwithproof wants to merge 4 commits into
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
requested review from
cigamit
and removed request for
a team
October 27, 2026 22:26
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
somethingwithproof
marked this pull request as draft
October 27, 2026 22:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Move the User Log, RRD Checker, Public Keys, and Package Repositories list bodies into Twig templates and controllers under
src/Controller. Controllers return Symfony HttpFoundation responses and receive rows, validated search text, and realm/type mappings explicitly.Keep Cacti's query, filter, pagination, sortable-header, authentication, CSRF, edit, and bulk-action paths. The table adapter preserves selection markup and saved column visibility. Database access stays on Cacti's existing
db_*helpers. This migration introduces no Doctrine or DBAL.Validation:
Edit and mutation flows retain their existing code and are not covered by the new route checks. GitHub CI is rerunning after the coverage fix.
Targets the Twig foundation branch and depends on its renderer and controller autoloading.
Local changed-line coverage passes the existing gate: 38/38 executable changed PHP lines covered (100.0%). This combines PHP 8.3/Xdebug controller tests with source-hashed coverage from the authenticated browser requests.