Repository navigation
fix(i18n): embed French JS strings with json_encode - #8556
Open
mael-chouteau wants to merge 1 commit into
Open
mael-chouteau wants to merge 1 commit into
mael-chouteau wants to merge 1 commit into
Conversation
Single-quoted PHP gettext in <script> breaks when the French translation contains an apostrophe. Use json_encode() as support.php already does so the apostrophe is string data. Fixes Cacti#8555
mael-chouteau
requested review from
TheWitness
and removed request for
a team
October 30, 2026 14:59
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
'<?php print __('...'); ?>'), which ends the string and skips the rest of the page script.json_encode(), matchingsupport.php, so the apostrophe is string data.__esc()would HTML-encode it and show'in dialog titles /.text()labels.Fixes #8555
Test plan