Repository navigation
Replace deprecated get_request_var_request() with get_request_var() - #431
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both replacements preserve the alias behavior, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
Replaces deprecated request-helper calls in the Intropage administration tabs with Cacti’s canonical get_request_var() helper, preserving existing behavior.
Changes:
- Updates the user and user-group settings tab checks to use
get_request_var().
| File | Description |
|---|---|
includes/settings.php |
Replaces both deprecated helper calls used to determine the selected settings tab. |
Review effort: Balanced
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
bmfmancini
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_request_var_request()is a deprecated (v1.0) alias ofget_request_var()in Cacti core (lib/html_utility.php). This PR replaces the remaining call sites with the canonical function. Behavior is unchanged because the alias simply forwards toget_request_var().Change
get_request_var_request(...)->get_request_var(...)Validation
php -lpasses on changed file(s).