Repository navigation
Fix servcheck test filter: display_name column renamed to name - #70
Merged
Merged
Conversation
plugin_servcheck's 0.3 upgrade renamed plugin_servcheck_test.display_name to name, but maint.php still referenced t.display_name in the schedules() and servcheck-test filter WHERE clauses (and \['display_name'] in the listing), causing 'Unknown column t.display_name' errors when filtering. Update the five plugin_servcheck_test references to name. The plugin_webseer_urls.display_name references are unaffected and left as-is.
TheWitness
requested review from
bmfmancini,
browniebraun,
cigamit and
xmacan
and
a balanced review from Copilot
September 29, 2026 16:04
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All Servcheck references were updated consistently while WebSeer references remain correctly unchanged.
Review effort: Balanced
Findings: None
What changed in this PR
Updates Maint’s Servcheck integration for the renamed name column in Servcheck 0.3.
Changes:
- Fixes schedule and association-tab filtering.
- Updates description lookup and test-name rendering.
| File | Description |
|---|---|
maint.php |
Replaces five stale Servcheck display_name references with name. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
browniebraun
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Filtering on the Maintenance schedules page (and the per-schedule Servcheck test association tab) throws:
Cause
plugin_servcheck's 0.3 upgrade renamed the test table's display column:but
maint.phpstill referenced the olddisplay_namecolumn onplugin_servcheck_test, so any filter that hits those queries fails.Fix
Update the five stale
plugin_servcheck_testreferences fromdisplay_nametoname:schedules()filter WHERE (the reported crash) —t.display_name→t.nameSELECT display_name→SELECT namet.display_name→t.name$test['display_name']→$test['name'](description cell + checkbox cell)The
plugin_webseer_urls.display_namereferences (that table still usesdisplay_name) are intentionally left unchanged.Testing
php -l maint.php— no syntax errors.plugin_servcheckthat the canonical column is nowname(its only remainingdisplay_namereference is the rename migration itself).