Repository navigation
Fixing SQL issues when there are no service checks to perform - #72
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes SQL syntax errors and adds a safeguard to prevent errors when there are no service checks to perform. The changes address issues that would occur when the $tests array is empty.
Changes:
- Fixed SQL syntax error by removing comma between WHERE conditions and properly concatenating the dynamic WHERE clause
- Added leading space to
$sql_wherevariable for proper SQL formatting - Wrapped the statistics collection loop in a
cacti_sizeof($tests)check to prevent iterating over empty arrays
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xmacan
approved these changes
Feb 4, 2026
browniebraun
previously approved these changes
Feb 4, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
browniebraun
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.