Repository navigation
ci: build staging against engine staging and require maintainer approval - #88
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
CI builds pull requests into
stagingagainst SleakEnginestaging, and pull requests intomainagainst SleakEnginemain. Both branches also require a maintainer's approval.Why
CI always built against engine
main, so a change that needs an engine change could not pass until the engine change had already shipped to every game. SleakEngine now has astagingbranch too (CanReader/SleakEngine,ci: route changes through staging).How it was verified
CI configuration and docs only. The workflow YAML parses; the engine checkouts in all three jobs (build matrix, shaders, smoke test) use the same
ENGINE_REF.Checklist
.spv(no shader changes)WorldMeta::CURRENT_VERSIONand handle old worlds (no save changes)