Skip to content

Add the PR #84 review probes for URL-version skipping - #86

Open
arberx wants to merge 1 commit into
mainfrom
arberx/url-version-review-probes
Open

arberx wants to merge 1 commit into
mainfrom
arberx/url-version-review-probes

Conversation

@arberx

@arberx arberx commented Nov 3, 2026

Copy link
Copy Markdown
Member

Context

These are the scratch probes written while reviewing #84 (skipUrlVersionsAfter). They were left untracked in the review workspace, and this PR keeps them in the repo.

Change

  • Adds test/zz-scratch-angleC-1.test.ts, test/zz-scratch-angleC-2.test.ts and test/zz-scratch-lead-1.test.ts. Each test builds a small fixture site, runs runSiteCrawl with skipUrlVersionsAfter on, and logs what the crawl did: requests, page rows, dead links, summary.urlVersions and checksums. They log rather than assert, so they pass whatever the crawl does.
  • Removes two unused expect imports, which were the only lint errors.
  • The change is test-only (test/ is not in the published files), so there is no version bump and merging does not publish.

Before merging

  • The probes put the canonical tag in <body>. Since Skip learned URL versions during site crawls #84, only a canonical the canonical audit accepts counts (one valid tag in the head), so on main these probes no longer trigger skipping. The regression tests for the five review findings are in test/crawl-url-versions.test.ts.
  • They add 11 tests and print JSON to the test output on every run.

Testing

  • pnpm run typecheck, pnpm run build, pnpm run lint, pnpm test (828 passing, 11 from these files), pnpm run test:e2e (11 passing).

🤖 Generated with Claude Code

The scratch probes written while reviewing #84, kept for reference.
Each one builds a small fixture site, runs runSiteCrawl with
skipUrlVersionsAfter and logs what the crawl did. They log rather than
assert.

Their canonical tags are in <body>, which the accepted-canonical rule
from #84 ignores, so on main they no longer trigger skipping. The
regression tests for the five review findings are in
test/crawl-url-versions.test.ts.

Removed two unused expect imports so lint passes.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant