Repository navigation
Conversation
The scratch probes written while reviewing #84, kept for reference. Each one builds a small fixture site, runs runSiteCrawl with skipUrlVersionsAfter and logs what the crawl did. They log rather than assert. Their canonical tags are in <body>, which the accepted-canonical rule from #84 ignores, so on main they no longer trigger skipping. The regression tests for the five review findings are in test/crawl-url-versions.test.ts. Removed two unused expect imports so lint passes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
These are the scratch probes written while reviewing #84 (
skipUrlVersionsAfter). They were left untracked in the review workspace, and this PR keeps them in the repo.Change
test/zz-scratch-angleC-1.test.ts,test/zz-scratch-angleC-2.test.tsandtest/zz-scratch-lead-1.test.ts. Each test builds a small fixture site, runsrunSiteCrawlwithskipUrlVersionsAfteron, and logs what the crawl did: requests, page rows, dead links,summary.urlVersionsand checksums. They log rather than assert, so they pass whatever the crawl does.expectimports, which were the only lint errors.test/is not in the publishedfiles), so there is no version bump and merging does not publish.Before merging
<body>. Since Skip learned URL versions during site crawls #84, only a canonical the canonical audit accepts counts (one valid tag in the head), so onmainthese probes no longer trigger skipping. The regression tests for the five review findings are intest/crawl-url-versions.test.ts.Testing
pnpm run typecheck,pnpm run build,pnpm run lint,pnpm test(828 passing, 11 from these files),pnpm run test:e2e(11 passing).🤖 Generated with Claude Code