fix(infra): remove anonymous public read access from MinIO bucket#1750
Open
MinitJain wants to merge 2 commits into
Open
fix(infra): remove anonymous public read access from MinIO bucket#1750MinitJain wants to merge 2 commits into
MinitJain wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…onymous-public-access
Member
|
please review the pr @greptileai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minio-setupcontainer ranmc anonymous set download capminio/capon startup, making the entire S3 bucket publicly readable at the network leveldocker-compose.ymlanddocker-compose.coolify.ymlSecurity Impact
With anonymous bucket access set, anyone who could reach port 9000 on the host could download any stored file directly (videos, audio, thumbnails) without authentication — bypassing all app-level access controls including private videos, password protection, and org membership checks. Presigned URLs are signed by the S3 credentials and do not require the bucket to be public.
Test plan
docker compose up— bucket created, no anonymous policy sethttp://localhost:9000/cap/<path>returns 403Greptile Summary
This PR removes the
mc anonymous set downloadcommand from theminio-setupcontainer in both docker-compose variants, closing a misconfiguration that made the entire storage bucket publicly readable at the network level. File access continues to work via the existing presigned URL flow, which does not require an open bucket policy.docker-compose.yml: Drops the anonymous download policy line from the local development setup.docker-compose.coolify.yml: Applies the same removal to the Coolify production deployment variant.Confidence Score: 5/5
Safe to merge — the change removes a two-line misconfiguration with no functional impact on the presigned-URL access path.
Both files delete a single
mc anonymous set downloadcommand and nothing else. The application's video/file access already routes through presigned URLs, so removing bucket-level public access has no effect on legitimate usage. The change is minimal and the risk of regression is very low.No files require special attention.
Important Files Changed
mc anonymous set download capminio/capfrom the minio-setup startup script, eliminating anonymous public read access to the bucket.mc anonymous set download capminio/${S3_BUCKET:-cap}from the minio-setup startup script, mirroring the fix in docker-compose.yml for the Coolify deployment variant.Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'upstream/m..." | Re-trigger Greptile