feat: add Cap deeplink controls and Raycast extension#1809
Open
tongshu2023 wants to merge 2 commits into
Open
Conversation
brin-security-scanner
Bot
added
the
contributor:verified
brin-security-scanner
Bot
added
the
pr:flagged
Brin PR Security ScanThis PR has findings that should be reviewed.
Findings:
Analyzed by Brin |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "icon": "assets/icon.png", | ||
| "author": "cap", | ||
| "license": "MIT", | ||
| "platforms": ["macOS", "Windows"], |
Contributor
There was a problem hiding this comment.
"Windows" in the platforms array is misleading: Raycast on Windows will attempt to open the cap-desktop:// deeplink, but that URL scheme is not registered on Windows, so every command silently does nothing. The list should be macOS-only to match the actual supported platform.
Suggested change
| "platforms": ["macOS", "Windows"], | |
| "platforms": ["macOS"], |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/raycast/package.json
Line: 8
Comment:
Cap desktop only runs on macOS. Including `"Windows"` in the `platforms` array is misleading: Raycast on Windows will attempt to open the `cap-desktop://` deeplink, but that URL scheme is not registered on Windows, so every command silently does nothing. The list should be macOS-only to match the actual supported platform.
```suggestion
"platforms": ["macOS"],
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+60
to
+62
| await open(deepLink); | ||
| await closeMainWindow(); | ||
| await showHUD(hudMessage); |
Contributor
There was a problem hiding this comment.
"mode": "no-view", which means there is no main Raycast window to close. closeMainWindow() is only meaningful in view-mode commands; in no-view mode it is a no-op at best and may throw at runtime. showHUD is the standard completion signal for no-view commands and dismisses the launcher itself — closeMainWindow() is not needed here.
Suggested change
| await open(deepLink); | |
| await closeMainWindow(); | |
| await showHUD(hudMessage); | |
| await open(deepLink); | |
| await showHUD(hudMessage); |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/raycast/src/lib/cap.ts
Line: 60-62
Comment:
All commands in this extension use `"mode": "no-view"`, which means there is no main Raycast window to close. `closeMainWindow()` is only meaningful in view-mode commands; in no-view mode it is a no-op at best and may throw at runtime. `showHUD` is the standard completion signal for no-view commands and dismisses the launcher itself — `closeMainWindow()` is not needed here.
```suggestion
await open(deepLink);
await showHUD(hudMessage);
```
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #1540
Summary
cap-desktop://action?...is recognized through the URL hostValidation
npm exec -- tsc -p tsconfig.json --noEmitinapps/raycastcargo fmt/cargo check -p cap-desktopin this environment because the Rust toolchain is not installed hereNotes